[Marketplace Contribution] Recorded Future Identity - Content Pack Update #30246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/xsoar-contrib_NicCas-contrib-IdentityRecordedFuture
|
Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @MosheEichler will very shortly look over your proposed changes. |
There was a problem hiding this comment.
Hey @NicCas
Thank you for your contribution!
Good work :)
Please see my little comments.
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again
Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
…re/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
…ture' into NicCas-contrib-IdentityRecordedFuture
Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml
Outdated
Show resolved
Hide resolved
Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.py
Outdated
Show resolved
Hide resolved
randomizerxd
suggested changes
Oct 20, 2023
| @@ -1,5 +1,7 @@ | |||
| import demistomock as demisto # noqa: F401 | |||
| from CommonServerPython import * # noqa: F401 | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
@NicCas Remove these empty lines to remove the diff
…re/IdentityRecordedFuture.py Add credential backwards compatibility. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
…re/IdentityRecordedFuture.yml Add credential backwards compatibility. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
…ture' into NicCas-contrib-IdentityRecordedFuture
Require credential parameter to be mandatory to ensure there is an API token before saving the instance.
There was a problem hiding this comment.
Hey @NicCas
Thank you for your fixes.
Please see my comments.
Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml
Outdated
Show resolved
Hide resolved
Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml
Outdated
Show resolved
Hide resolved
MosheEichler
added
the
pending-contributor
…re/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
…re/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
…ture' into NicCas-contrib-IdentityRecordedFuture
…ture' into NicCas-contrib-IdentityRecordedFuture
…ture' into NicCas-contrib-IdentityRecordedFuture
MosheEichler
approved these changes
Oct 25, 2023
MosheEichler
merged commit c4068a8
into
demisto:contrib/xsoar-contrib_NicCas-contrib-IdentityRecordedFuture
19 of 23 checks passed
3 tasks
MosheEichler
added a commit
that referenced
this pull request
Oct 27, 2023
…date (#30391) * [Marketplace Contribution] Recorded Future Identity - Content Pack Update (#30246) * "contribution update to pack "Recorded Future Identity"" * Update Packs/IdentityRecordedFuture/ReleaseNotes/1_2_0.md Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.py Add credential backwards compatibility. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Add credential backwards compatibility. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Added credential backwards compatibility * Update IdentityRecordedFuture.yml Require credential parameter to be mandatory to ensure there is an API token before saving the instance. * Changed parameter name from 'token' to 'credential' * Uses new 'credential' parameter for api token * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Fixed formatting and updated docker image * Updated docker image --------- Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Adding junit output support for test-content command (#29906) Adding junit output support for test-content command #29906 * gitlab CI build parameters (#30392) gitlab CI build parameters #30392 * fix merge to master pipeline (#30396) fix merge to master pipeline #30396 * fix SDK nightly build on destroy instance & Content Merge build (#30397) fix SDK nightly build on destroy instance & Content Merge build #30397 * RegexGroups - Empty Results on Error (#30386) * implemented fetch-events * add tests * fix tests * change to empty list upon error * revert * fixes --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
…date (#30391) * [Marketplace Contribution] Recorded Future Identity - Content Pack Update (#30246) * "contribution update to pack "Recorded Future Identity"" * Update Packs/IdentityRecordedFuture/ReleaseNotes/1_2_0.md Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.py Add credential backwards compatibility. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Add credential backwards compatibility. Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Added credential backwards compatibility * Update IdentityRecordedFuture.yml Require credential parameter to be mandatory to ensure there is an API token before saving the instance. * Changed parameter name from 'token' to 'credential' * Uses new 'credential' parameter for api token * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Update Packs/IdentityRecordedFuture/Integrations/IdentityRecordedFuture/IdentityRecordedFuture.yml Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Fixed formatting and updated docker image * Updated docker image --------- Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> * Adding junit output support for test-content command (#29906) Adding junit output support for test-content command #29906 * gitlab CI build parameters (#30392) gitlab CI build parameters #30392 * fix merge to master pipeline (#30396) fix merge to master pipeline #30396 * fix SDK nightly build on destroy instance & Content Merge build (#30397) fix SDK nightly build on destroy instance & Content Merge build #30397 * RegexGroups - Empty Results on Error (#30386) * implemented fetch-events * add tests * fix tests * change to empty list upon error * revert * fixes --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: Koby Meir <kobymeir@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Contributor
@NicCas
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.