[ASM] - EXPANDER 4377 - ServiceNow ITSM Enrichment #30296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix format of ASM Enrichment playbook - Add SN ITSM Enrichment to main Enrichment playbook
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/PaloAltoNetworks_EXPANDR-4377
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed. |
content-bot
added
Community
Contribution Form Filled
johnnywilkes
suggested changes
Oct 18, 2023
| quietmode: 0 | ||
| isoversize: false | ||
| isautoswitchedtoquietmode: false | ||
| '27': |
There was a problem hiding this comment.
@BigEasyJ , in this task (or a separate task) we need to make sure SNOW-ITSM integration is enabled or there is no reason to continue.
johnnywilkes
approved these changes
Oct 18, 2023
|
LGTM |
capanw
approved these changes
Oct 18, 2023
|
@ShirleyDenkberg , Can you please review? |
| id: d3007e79-c33c-4f6f-83f3-e7ee98dfb3b2 | ||
| version: -1 | ||
| name: Build ServiceNow query - description | ||
| description: Set the beginning of a key used for querying ServiceNow using SN descriptions and a timestamp. |
There was a problem hiding this comment.
Suggested change
| description: Set the beginning of a key used for querying ServiceNow using SN descriptions and a timestamp. | |
| description: Set the beginning of a key used for querying ServiceNow using ServiceNow descriptions and a timestamp. |
| id: 962733bf-859d-4823-8d39-478d4fb092e8 | ||
| version: -1 | ||
| name: Build ServiceNow query - short description | ||
| description: Set the remaining query value with SN short descriptions for querying ServiceNow. |
There was a problem hiding this comment.
Suggested change
| description: Set the remaining query value with SN short descriptions for querying ServiceNow. | |
| description: Set the remaining query value with ServiceNow short descriptions for querying ServiceNow. |
| id: 449135ee-dbef-48c5-8e00-597ce6f55cf0 | ||
| version: -1 | ||
| name: Were search terms provided? | ||
| description: Conditional to check if values were provided to the search terms input or not. |
There was a problem hiding this comment.
Suggested change
| description: Conditional to check if values were provided to the search terms input or not. | |
| description: Check if values were provided to the search terms input or not. |
| id: c9c5b720-7cd3-406e-8a2e-3af77876dc8b | ||
| version: -1 | ||
| name: Were any assignees found? | ||
| description: Conditional to check if any assignees were found in the assigned_to property of retrieved ServiceNow tickets. |
There was a problem hiding this comment.
Suggested change
| description: Conditional to check if any assignees were found in the assigned_to property of retrieved ServiceNow tickets. | |
| description: Check if any assignees were found in the assigned_to property of retrieved ServiceNow tickets. |
| - key: search_terms | ||
| value: {} | ||
| required: true | ||
| description: Search terms to be used in the ServiceNow ITSM query search |
There was a problem hiding this comment.
Suggested change
| description: Search terms to be used in the ServiceNow ITSM query search | |
| description: Search terms to be used in the ServiceNow ITSM query search. |
|
|
||
| ### Integrations | ||
|
|
||
| * ServiceNow v2 |
There was a problem hiding this comment.
Suggested change
| * ServiceNow v2 | |
| ServiceNow v2 |
|
@sapirshuker When there is only one item in a list, no hyphen is needed. @johnnywilkes @capanw @melamedbn @sapirshuker Doc review completed. |
|
Hey, @BigEasyJ |
|
@sapirshuker updated and ready |
sapirshuker
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6690165 |
|
Build process failed due an known issue: CIAC-6419 |
sapirshuker
previously approved these changes
Oct 22, 2023
sapirshuker
dismissed
their stale review
@BigEasyJ please resolve the conflicts
|
Hey, @BigEasyJ |
sapirshuker
added
ready-for-instance-test
|
Build process failed due an known issue: CIAC-6419 |
sapirshuker
approved these changes
Oct 24, 2023
sapirshuker
merged commit 5401f1f
into
demisto:contrib/PaloAltoNetworks_EXPANDR-4377
24 of 25 checks passed
5 tasks
sapirshuker
pushed a commit
that referenced
this pull request
Oct 25, 2023
* ReadMe and PNG * Add ASM ServiceNow ITSM Enrichment playbook - Fix format of ASM Enrichment playbook - Add SN ITSM Enrichment to main Enrichment playbook * Add release notes * Update release notes * Update README, formatting, pack ignore * Validation fix * Change fromversion * Add integration enabled check * Fix formatting * Doc revisions Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* ReadMe and PNG * Add ASM ServiceNow ITSM Enrichment playbook - Fix format of ASM Enrichment playbook - Add SN ITSM Enrichment to main Enrichment playbook * Add release notes * Update release notes * Update README, formatting, pack ignore * Validation fix * Change fromversion * Add integration enabled check * Fix formatting * Doc revisions Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
EXPANDR-4377
Description
Create a new playbook to query ServiceNow ITSM for service owners.
Must have