Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XDR Expandr-3361 #30308

Merged
merged 30 commits into from Nov 5, 2023
Merged

XDR Expandr-3361 #30308

merged 30 commits into from Nov 5, 2023

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-3361

Description

There was a new argument 'public_ip_list' added to the Get-Endpoint API call. I updated the Core and XDR integrations to allow this new argument.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 18, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_XDR-EXPANDR-3361 October 18, 2023 18:02
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review

ShirleyDenkberg
ShirleyDenkberg reviewed Oct 19, 2023
View reviewed changes
Packs/ApiModules/ReleaseNotes/2_2_21.md Outdated Show resolved Hide resolved
Packs/Core/ReleaseNotes/2_0_19.md Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/5_2_2.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Oct 19, 2023
@ShirleyDenkberg
Copy link
Contributor

@sapirshuker @dansterenson Doc review completed.

johnnywilkes and others added 2 commits October 19, 2023 08:42
@johnnywilkes @ShirleyDenkberg
Apply suggestions from code review
d605bff 
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@johnnywilkes
Merge branch 'contrib/PaloAltoNetworks_XDR-EXPANDR-3361' into XDR-EXP…
360fea8 
…ANDR-3361
@johnnywilkes
Copy link
Contributor Author

@sapirshuker , @dansterenson , none of the validation/pre-commit errors seem to be related to changes I made

@johnnywilkes johnnywilkes mentioned this pull request Oct 19, 2023
Merged
5 tasks
@johnnywilkes
Copy link
Contributor Author

@sapirshuker , @dansterenson , none of the validation/pre-commit errors seem to be related to changes I made

Same

@omerKarkKatz omerKarkKatz self-assigned this Oct 29, 2023
@sapirshuker
Copy link
Contributor

sapirshuker commented Oct 29, 2023 •
edited

@melamedbn / @sapirshuker , updated wording as we discussed: 10fe2eb

@sapirshuker , resolved all GR100 errors 0e08a7a

Hey @johnnywilkes
The GR100 validation error still exists:
/home/circleci/project/Packs/CortexXDR/IncidentTypes/incidenttype-XDR_Device_Control_Violations.json - [GR100] /home/circleci/project/Packs/CortexXDR/IncidentTypes/Cortex_XDR_Incident.json - [GR100]

@johnnywilkes
Copy link
Contributor Author

@melamedbn / @sapirshuker , updated wording as we discussed: 10fe2eb
@sapirshuker , resolved all GR100 errors 0e08a7a

Hey @johnnywilkes The GR100 validation error still exists: /home/circleci/project/Packs/CortexXDR/IncidentTypes/incidenttype-XDR_Device_Control_Violations.json - [GR100] /home/circleci/project/Packs/CortexXDR/IncidentTypes/Cortex_XDR_Incident.json - [GR100]

@sapirshuker fixed in GR100 and README

@dansterenson dansterenson removed their request for review October 30, 2023 14:36
@sapirshuker sapirshuker added pending-demo Demo pending post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Nov 1, 2023
@content-bot
Copy link
Collaborator

content-bot commented Nov 2, 2023 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6801330

@omerKarkKatz omerKarkKatz self-requested a review November 5, 2023 09:49
@omerKarkKatz omerKarkKatz removed their assignment Nov 5, 2023
@sapirshuker
Copy link
Contributor

Hey, @johnnywilkes @andrew-paloalto
You have conflicts in the PR and I can't merge it to internal PR.
I can’t merge to your PR to resolve it since I don’t have permission.
Can you please resolve the conflicts or invite me as a collaborator to your contribution?

@johnnywilkes
Copy link
Contributor Author

@sapirshuker , i have resolved conflicts. This should be ready to merge

@sapirshuker sapirshuker added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Nov 5, 2023
@sapirshuker sapirshuker self-requested a review November 5, 2023 15:38
@sapirshuker sapirshuker merged commit 1c84ef4 into demisto:contrib/PaloAltoNetworks_XDR-EXPANDR-3361 Nov 5, 2023
18 of 21 checks passed
@content-bot content-bot mentioned this pull request Nov 5, 2023
Merged
5 tasks
ShahafBenYakir pushed a commit that referenced this pull request Nov 14, 2023
@content-bot @johnnywilkes
@ShirleyDenkberg @sapirshuker @melamedbn
XDR Expandr-3361 (#30662)
c76c951 
* XDR Expandr-3361 (#30308)

* updates

* README and lint updates

* RN

* docker

* update RN

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* bump ver

* bump docker

* PR feedback

* test change XDR MP on integration

* more MP check

* GR100 fixes

* update RN

* description changes and bump

* GR100 and README

* bump XDR ver

* bump ver

* fix GR100

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* resolve conflicts

* fix period issue

* update docker image

* revert . issue

* fix gr100

* add RN to cft01

* update RN

* review fix

* update docker image

* update RN

* update RN- core

* update RN, change docker image, delete RN for APIModule

* update RN, change docker image

* Update 5_2_6.md

* update RN, change docker image

* add pack ignore, add timeout

* fix RN and docs

* Update 1_0_1.md

* fix rn

* Bump pack from version ctf01 to 1.0.2.

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: melamedbn <bmelamed@paloaltonetworks.com>
Co-authored-by: Content Bot <bot@demisto.com>
sapirshuker added a commit that referenced this pull request Dec 21, 2023
@content-bot @johnnywilkes
@ShirleyDenkberg @sapirshuker @melamedbn
XDR Expandr-3361 (#30662)
da20c21 
* XDR Expandr-3361 (#30308)

* updates

* README and lint updates

* RN

* docker

* update RN

* Apply suggestions from code review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* bump ver

* bump docker

* PR feedback

* test change XDR MP on integration

* more MP check

* GR100 fixes

* update RN

* description changes and bump

* GR100 and README

* bump XDR ver

* bump ver

* fix GR100

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* resolve conflicts

* fix period issue

* update docker image

* revert . issue

* fix gr100

* add RN to cft01

* update RN

* review fix

* update docker image

* update RN

* update RN- core

* update RN, change docker image, delete RN for APIModule

* update RN, change docker image

* Update 5_2_6.md

* update RN, change docker image

* add pack ignore, add timeout

* fix RN and docs

* Update 1_0_1.md

* fix rn

* Bump pack from version ctf01 to 1.0.2.

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: melamedbn <bmelamed@paloaltonetworks.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@melamedbn melamedbn melamedbn approved these changes

@sapirshuker sapirshuker sapirshuker approved these changes

@omerKarkKatz omerKarkKatz Awaiting requested review from omerKarkKatz

Assignees

@melamedbn melamedbn

@sapirshuker sapirshuker

@ShirleyDenkberg ShirleyDenkberg

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-demo Demo pending post-demo ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
6 participants
@johnnywilkes @content-bot @ShirleyDenkberg @sapirshuker @melamedbn @omerKarkKatz