New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add list_target to f5-silverline-ip-object-delete #30309
Merged
samuelFain
merged 13 commits into
master
from
bugfix/XSUP-29244/ip-object-delete-command
Oct 23, 2023
Merged
Add list_target to f5-silverline-ip-object-delete #30309
samuelFain
merged 13 commits into
master
from
bugfix/XSUP-29244/ip-object-delete-command
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasBeilin
reviewed
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please take a look at my comments.
JasBeilin
approved these changes
Oct 22, 2023
@JasBeilin Doc review completed. Looks good. |
5 tasks
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Add list_target to f5-silverline-ip-object-delete * Add list_target argument logic * Update docker Image & release notes; format fixes * Update release notes * Add known_words * Update delete command to default to proxy * Fix typo in human readable * Update test_delete_ip_objects_command UT * Update docker image * Remove explicit None return * Fix release notes typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: XSUP-29244
Description
Add
list_target
arguemnt tof5-silverline-ip-object-delete
command for more versatile IP object deletion options (proxy, routed or both).Must have