Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list_target to f5-silverline-ip-object-delete #30309

Merged
merged 13 commits into from Oct 23, 2023

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Oct 18, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-29244

Description

Add list_target arguemnt to f5-silverline-ip-object-delete command for more versatile IP object deletion options (proxy, routed or both).

Must have

  • Tests
  • Documentation

@samuelFain samuelFain self-assigned this Oct 21, 2023
@samuelFain samuelFain marked this pull request as ready for review October 21, 2023 23:16
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please take a look at my comments.

@ShirleyDenkberg
Copy link
Contributor

@JasBeilin Doc review completed. Looks good.

@samuelFain samuelFain merged commit 791338f into master Oct 23, 2023
21 of 25 checks passed
@samuelFain samuelFain deleted the bugfix/XSUP-29244/ip-object-delete-command branch October 23, 2023 16:00
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Add list_target to f5-silverline-ip-object-delete

* Add list_target argument logic

* Update docker Image & release notes; format fixes

* Update release notes

* Add known_words

* Update delete command to default to proxy

* Fix typo in human readable

* Update test_delete_ip_objects_command UT

* Update docker image

* Remove explicit None return

* Fix release notes typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants