Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Azure Compute] - Support altering/Multiple Subscription IDs, Resource Group #30315

Merged
merged 23 commits into from Nov 12, 2023
Merged

[Azure Compute] - Support altering/Multiple Subscription IDs, Resource Group #30315

merged 23 commits into from Nov 12, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Oct 19, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

  • Add instance config params Default Resource Group Name.
  • Add command arguments to override default subscription_id and resource_group_name.
  • Add sections to integration instance parameters
  • Bumped API version to 2023-03-01.

Must have

  • Tests
  • Documentation

@mmhw mmhw requested a review from bziser October 19, 2023 10:54
@mmhw mmhw self-assigned this Oct 19, 2023
@mmhw mmhw requested a review from DeanArbel October 31, 2023 13:45
DeanArbel
DeanArbel approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent implementation.

Packs/AzureCompute/Integrations/AzureCompute_v2/AzureCompute_v2.py Show resolved Hide resolved
@mmhw mmhw force-pushed the MW/CIAC-6560/Azure_Compute/Multiple_Subscription_IDs_and_Resource_Group branch from 8e8d645 to 9c51b32 Compare November 6, 2023 14:55
@mmhw mmhw merged commit 4fc977e into master Nov 12, 2023
21 of 22 checks passed
@mmhw mmhw deleted the MW/CIAC-6560/Azure_Compute/Multiple_Subscription_IDs_and_Resource_Group branch November 12, 2023 08:18
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
@mmhw
[Azure Compute] - Support altering/Multiple Subscription IDs, Resourc…
0c0ee35 
…e Group (#30315)

* First commit

* Fix the unit tests

* Add RN

* Update the docker images

* generate-docs

* Update 2 commands

* Update the docker image

* Fix the unit tests

* Update the RN

* Update the docker image

* azure-list-resource-groups add support for nextLink

* Fix

* Update the RN

* Update the docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeanArbel DeanArbel DeanArbel approved these changes

@bziser bziser Awaiting requested review from bziser

Assignees

@mmhw mmhw

Labels
docs-approved
Projects
None yet
Milestone
No milestone
2 participants
@mmhw @DeanArbel