fix added warning IP list too large #30341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix added warning * Added fqdn parameter to qualys-schedule-scan-create command
content-bot
added
Contribution
MosheEichler
approved these changes
Oct 23, 2023
|
@MosheEichler Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
|
Hello to all, I have a few questions, Do I have to do anything else, such as correcting the Review Release Notes or you will be responsible for that? Thanks for your help |
|
There is no need for you to do anything, we are working on it and hope to merge it today or tomorrow. Have a nice day, |
5 tasks
* SysAid add get file (#30583) * SysAid add get file * Fixed error SysAid add get file * docker * Add file output * Update Packs/SysAid/ReleaseNotes/1_0_13.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/SysAid/Integrations/SysAid/SysAid.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/SysAid/Integrations/SysAid/SysAid.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/SysAid/Integrations/SysAid/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed UT --------- Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
* SentinelOne v 3 2 12 (#30626) * Bug Fixes * updated the docker image * updated the release notes * making chages in threat request call * review comment fix * fixed release notes * docker --------- Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
* init * started fetch * finished fetch * name changes * fixed output in yml * added command names * mirroring part 1 * added incident type * fixed incident type * fethcing logic works! * cmnd: netcraft-attack-report * cmnd: netcraft-attack-report complete * reference new pack in old * cmnd: netcraft-attack-report complete * session changes * added classifier * added commands * commands continued * commands continued * order change * test-module * examples init * session changes * pre update * finished code * added TPB * unit-tests init * test_data TO BE DELETED * test_data TO BE DELETED * test_data complete * test_data.py complete * unit-tests continued * unit-tests complete * fixed KeyError bug * fixed SubmissionNextToken bug * fixed pagination bug * remove unused test data * improved UI * silence secret ignore * silence line-too-long * silence secret ignore * added readme; fixed png * tests/format complete * default args * session changes * session changes * CR changes * finished docs * fix docs * fix docs * added layout * clearer description * add error for no file * add error for no file * demo changes part 1 * demo changes part 2 * demo changes part 3 * demo changes part 4 * demo changes part 5 * fixed unit-tests * update escalate docs * authorise => authorize * match case => if-elif * CR changes * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed unit-tests * remove trailing whitespace * try running build * fixed upload bug * name change to avoid conflict * pack readme part 1 * release notes * add image * removed unnecessary files * cleaned build problems * pack readme part 2 * readme complete * readme complete * added layout, mapper, type; not formatted * capitalize 'service' * get_file_path * trial fix for unittests * fixed unit-tests * update docker * small changes * doc review changes * update TPB * silence secret detections * classifier fixed * demo changes * demo changes * small change * UI works * fix tests and docs * update docker * added types to yaml * fixed file submit bug * layout for xsoar only * build wars: round 1 * build wars: round 2 * build wars: round 3 * build wars: round 4 * build wars: round 5 * build wars: round 6 * build wars: round 7 * Update conf.json * remove email address * fix TPB * incease retry-interval * raised timeout threshold * update docker * raised from_version --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
|
Hello all, Do you know approximately if the merge into demisto/content master branch will be finished on a few days? Thanks for your help, |
|
Hello to all, Do you know when the merging into the master branch of demisto/content would be ready? Sorry for the inconvenence, but we expected to be completed at most by the Wednesday of this week and it is delaying Thanks for all, Regards, |
|
Thank you for your contribution. Thanks again. |
MosheEichler
deleted the
contrib/franciscojoseabellan_warn_IP_list_large
branch
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* fix added warning IP list too large (#30217) * fix added warning * Added fqdn parameter to qualys-schedule-scan-create command * flake8 * pre commit * RN * Update Packs/qualys/ReleaseNotes/2_0_6.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix description * docker * RN * SysAid add get file (#30718) * SysAid add get file (#30583) * SysAid add get file * Fixed error SysAid add get file * docker * Add file output * Update Packs/SysAid/ReleaseNotes/1_0_13.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/SysAid/Integrations/SysAid/SysAid.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/SysAid/Integrations/SysAid/SysAid.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/SysAid/Integrations/SysAid/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed UT --------- Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * update conf file (#30743) * remove/change values (#30728) * SentinelOne v 3 2 12 (#30740) * SentinelOne v 3 2 12 (#30626) * Bug Fixes * updated the docker image * updated the release notes * making chages in threat request call * review comment fix * fixed release notes * docker --------- Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com> * Netcraft Revamp (#29527) * init * started fetch * finished fetch * name changes * fixed output in yml * added command names * mirroring part 1 * added incident type * fixed incident type * fethcing logic works! * cmnd: netcraft-attack-report * cmnd: netcraft-attack-report complete * reference new pack in old * cmnd: netcraft-attack-report complete * session changes * added classifier * added commands * commands continued * commands continued * order change * test-module * examples init * session changes * pre update * finished code * added TPB * unit-tests init * test_data TO BE DELETED * test_data TO BE DELETED * test_data complete * test_data.py complete * unit-tests continued * unit-tests complete * fixed KeyError bug * fixed SubmissionNextToken bug * fixed pagination bug * remove unused test data * improved UI * silence secret ignore * silence line-too-long * silence secret ignore * added readme; fixed png * tests/format complete * default args * session changes * session changes * CR changes * finished docs * fix docs * fix docs * added layout * clearer description * add error for no file * add error for no file * demo changes part 1 * demo changes part 2 * demo changes part 3 * demo changes part 4 * demo changes part 5 * fixed unit-tests * update escalate docs * authorise => authorize * match case => if-elif * CR changes * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fixed unit-tests * remove trailing whitespace * try running build * fixed upload bug * name change to avoid conflict * pack readme part 1 * release notes * add image * removed unnecessary files * cleaned build problems * pack readme part 2 * readme complete * readme complete * added layout, mapper, type; not formatted * capitalize 'service' * get_file_path * trial fix for unittests * fixed unit-tests * update docker * small changes * doc review changes * update TPB * silence secret detections * classifier fixed * demo changes * demo changes * small change * UI works * fix tests and docs * update docker * added types to yaml * fixed file submit bug * layout for xsoar only * build wars: round 1 * build wars: round 2 * build wars: round 3 * build wars: round 4 * build wars: round 5 * build wars: round 6 * build wars: round 7 * Update conf.json * remove email address * fix TPB * incease retry-interval * raised timeout threshold * update docker * raised from_version --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * docker * change map * change scan * revert --------- Co-authored-by: franciscojoseabellan <134506710+franciscojoseabellan@users.noreply.github.com> Co-authored-by: MosheEichler <meichler@paloaltonetworks.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Giorgio <147415442+giocupelli84@users.noreply.github.com> Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com> Co-authored-by: Adi Bamberger Edri <72088126+BEAdi@users.noreply.github.com> Co-authored-by: munna-metron <82433049+munna-metron@users.noreply.github.com> Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@franciscojoseabellan
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have