Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process email generic v2 #30355

Merged
merged 5 commits into from Oct 24, 2023
Merged

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@rundssoar

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Added support for rasterizing plain-text mails.
The default behaviour stays to render Email.HTML, but in case that is not available, this PR uses the Email.Text to render the Screenshot of the Mail

* Allow rasterization of plain-text mails

* update relase notes

* apply format for release notes

* Remove Period in yml file

---------

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! pending-demo Demo pending Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR Security Review labels Oct 23, 2023
@ShirleyDenkberg
Copy link
Contributor

@MosheEichler Doc review completed.

MosheEichler and others added 2 commits October 23, 2023 16:39
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@MosheEichler
Copy link
Contributor

Hey @DeanArbel,
This PR needs a force merge since it fails on:
Content item 'Process Email - Generic v2' using content items: attachmentitem, emailimage, deleteEmptyField which cannot be found in the repository.
Which is a known issue according to @ilaner .

@ilaner
Copy link
Contributor

ilaner commented Oct 24, 2023

Hey @DeanArbel, This PR needs a force merge since it fails on: Content item 'Process Email - Generic v2' using content items: attachmentitem, emailimage, deleteEmptyField which cannot be found in the repository. Which is a known issue according to @ilaner .

deleteEmptyField is a known issue.

For attachmentitem, emailimage we need to open a new issue.

Any way, there is no risk to force merge this.

@DeanArbel DeanArbel merged commit adc7fda into master Oct 24, 2023
16 of 18 checks passed
@DeanArbel DeanArbel deleted the contrib/rundssoar_process-email-generic-v2 branch October 24, 2023 12:56
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Process email generic v2 (#30159)

* Allow rasterization of plain-text mails

* update relase notes

* apply format for release notes

* Remove Period in yml file

---------

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* revert to master

* RN

* Update Packs/Phishing/ReleaseNotes/3_5_29.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: rundssoar <139948408+rundssoar@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ForceMerge Internal PR pending-demo Demo pending Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
7 participants