[ASM] EXPANDR-1576 - Remediaiton guidance API changes #30374

capanw · 2023-10-24T16:58:14Z

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

In Progress
Ready
In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-1576

Description

Makes changes to use Remediation Guidance API.

Must have

Tests
Documentation

content-bot · 2023-10-24T17:01:25Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MosheEichler will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2023-10-24T17:01:26Z

Hi @capanw, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

capanw · 2023-10-24T17:21:41Z

@johnnywilkes @BigEasyJ Please review when you guys get a chance

johnnywilkes · 2023-10-25T12:37:07Z

@ShirleyDenkberg , can you please review?

johnnywilkes

@capanw , some small things to fix

...urfaceManagement/Integrations/CortexAttackSurfaceManagement/CortexAttackSurfaceManagement.py

...rfaceManagement/Integrations/CortexAttackSurfaceManagement/CortexAttackSurfaceManagement.yml

...urfaceManagement/Integrations/CortexAttackSurfaceManagement/CortexAttackSurfaceManagement.py

Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackSurfaceManagement/README.md

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert.yml

Packs/CortexAttackSurfaceManagement/pack_metadata.json

…viceNow_Notification_README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…a_Notification_README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…a_Notification.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…_Alert.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

…il_Notification.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

johnnywilkes

@capanw , thanks for making the changes

BigEasyJ · 2023-10-27T15:25:01Z

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Email_Notification.yml

@@ -306,7 +260,12 @@ inputs:
  required: true
  description: Body of the notification (email or ticket) sent to the potential service owner.
  playbookInputQuery:
+- key: RemediationGuidance
+  value: {}
+  required: true


Does this need to be required?

In the "Cortex ASM - Remediation Guidance" playbook, we set the RemediationGuidance key regardless if the Remediation guidance is available or not. So, we will always have this key set. Hence, made this required for the Email/Jira/ServiceNow playbooks

BigEasyJ · 2023-10-27T15:25:21Z

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Jira_Notification.yml

@@ -283,7 +237,12 @@ inputs:
  required: true
  description: The Jira project key to associate with the issue.
  playbookInputQuery:
+- key: RemediationGuidance
+  value: {}
+  required: true


Does this need to be required?

Same as above

BigEasyJ · 2023-10-27T15:25:39Z

Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ServiceNow_Notification.yml

@@ -258,7 +213,12 @@ inputs:
  required: true
  description: Body of the notification (email or ticket) sent to the potential service owner.
  playbookInputQuery:
+- key: RemediationGuidance
+  value: {}
+  required: true


Does this need to be required?

Same as above

* Remediaiton guidance API changes * Release notes updates * Fixes * Update readme * Misc changes to release notes * Misc changes * Update docker tags * Updated results and response files * Reverting few changes * Updated logic * Updated wording on inputs * Misc changes * Updated release version * Udpated if logic condition * Description changes * Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ServiceNow_Notification_README.md * Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_8.md * Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackSurfaceManagement/README.md * Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Jira_Notification_README.md * Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackSurfaceManagement/README.md * Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackSurfaceManagement/README.md * Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackSurfaceManagement/README.md * Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Jira_Notification.yml * Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackSurfaceManagement/README.md * Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert.yml * Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Email_Notification.yml * Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_8.md * Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_8.md * Read me updates --------- Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com> Co-authored-by: John <40349459+BigEasyJ@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

Remediaiton guidance API changes

69bee81

content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Oct 24, 2023

content-bot changed the base branch from master to contrib/capanw_EXPANDR-1576 October 24, 2023 17:01

content-bot assigned MosheEichler and melamedbn Oct 24, 2023

content-bot added the Security Review label Oct 24, 2023

content-bot requested review from melamedbn and MosheEichler October 24, 2023 17:01

Release notes updates

b782860

capanw changed the base branch from contrib/capanw_EXPANDR-1576 to master October 24, 2023 17:20

capanw marked this pull request as draft October 24, 2023 17:21

capanw and others added 7 commits October 24, 2023 10:22

Merge branch 'master' into EXPANDR-1576

3714010

Fixes

5cb29a8

Update readme

962ca01

Misc changes to release notes

0e15332

Misc changes

637c305

Update docker tags

f15ea73

Merge branch 'master' into EXPANDR-1576

78d1bc3

melamedbn removed their request for review October 25, 2023 10:49

johnnywilkes suggested changes Oct 25, 2023

View reviewed changes

BigEasyJ suggested changes Oct 25, 2023

View reviewed changes

Updated results and response files

2966c59

capanw and others added 16 commits October 26, 2023 14:27

Udpated if logic condition

b9c6b4e

Description changes

faf65dd

Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Ser…

8ab90a9

…viceNow_Notification_README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_8.md

5a6619b

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackS…

15b9c01

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Jir…

f6712ae

…a_Notification_README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackS…

a7529cd

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackS…

d1eafdf

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackS…

32aeaaf

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Jir…

5cbf230

…a_Notification.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Integrations/CortexAttackS…

b8c377e

…urfaceManagement/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM…

5eb393a

…_Alert.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_Ema…

e6177e3

…il_Notification.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_8.md

00fb9d8

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CortexAttackSurfaceManagement/ReleaseNotes/1_7_8.md

ab53776

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Read me updates

4da35a5

capanw changed the base branch from master to contrib/capanw_EXPANDR-1576 October 27, 2023 00:25

Merge branch 'contrib/capanw_EXPANDR-1576' into EXPANDR-1576

a568ac8

johnnywilkes approved these changes Oct 27, 2023

View reviewed changes

BigEasyJ reviewed Oct 27, 2023

View reviewed changes

BigEasyJ approved these changes Oct 27, 2023

View reviewed changes

capanw marked this pull request as ready for review October 27, 2023 15:45

MosheEichler approved these changes Oct 30, 2023

View reviewed changes

Merge branch 'contrib/capanw_EXPANDR-1576' into EXPANDR-1576

807b306

MosheEichler merged commit dfed641 into demisto:contrib/capanw_EXPANDR-1576 Oct 30, 2023
11 of 14 checks passed

content-bot mentioned this pull request Oct 30, 2023

[ASM] EXPANDR-1576 - Remediaiton guidance API changes #30536

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASM] EXPANDR-1576 - Remediaiton guidance API changes #30374

[ASM] EXPANDR-1576 - Remediaiton guidance API changes #30374

capanw commented Oct 24, 2023

content-bot commented Oct 24, 2023

content-bot commented Oct 24, 2023

capanw commented Oct 24, 2023

johnnywilkes commented Oct 25, 2023

johnnywilkes left a comment

johnnywilkes left a comment

BigEasyJ Oct 27, 2023

capanw Oct 27, 2023

BigEasyJ Oct 27, 2023

capanw Oct 27, 2023

BigEasyJ Oct 27, 2023

capanw Oct 27, 2023

[ASM] EXPANDR-1576 - Remediaiton guidance API changes #30374

[ASM] EXPANDR-1576 - Remediaiton guidance API changes #30374

Conversation

capanw commented Oct 24, 2023

Contributing to Cortex XSOAR Content

Status

Related Issues

Description

Must have

content-bot commented Oct 24, 2023

content-bot commented Oct 24, 2023

capanw commented Oct 24, 2023

johnnywilkes commented Oct 25, 2023

johnnywilkes left a comment

Choose a reason for hiding this comment

johnnywilkes left a comment

Choose a reason for hiding this comment

BigEasyJ Oct 27, 2023

Choose a reason for hiding this comment

capanw Oct 27, 2023

Choose a reason for hiding this comment

BigEasyJ Oct 27, 2023

Choose a reason for hiding this comment

capanw Oct 27, 2023

Choose a reason for hiding this comment

BigEasyJ Oct 27, 2023

Choose a reason for hiding this comment

capanw Oct 27, 2023

Choose a reason for hiding this comment