[Marketplace Contribution] Recorded Future Attack Surface Intelligence - Content Pack Update #30474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/xsoar-contrib_NicCas-contrib-RecordedFutureASI
|
Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @sapirshuker will very shortly look over your proposed changes. |
… into NicCas-contrib-RecordedFutureASI
… into NicCas-contrib-RecordedFutureASI
sapirshuker
requested changes
Oct 29, 2023
There was a problem hiding this comment.
Thank you for your contribution!
Good work :)
Please see my comments
You can add the fixes / changes by using the resubmit option resubmit-a-content-pack, or by using GitHub Codespaces - GitHub Codespaces documentation
Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml
Show resolved
Hide resolved
| @@ -3,7 +3,7 @@ | |||
| "prevName": "Recorded Future ASI", | |||
| "description": "Helps you take risk prioritization to the next level by helping you identify the biggest weaknesses within your attack surface.", | |||
| "support": "partner", | |||
| "currentVersion": "2.0.9", | |||
There was a problem hiding this comment.
This is not really a big change, please change the version to 2.0.10. (in the release note and in the pack metadata.json)
Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml
Outdated
Show resolved
Hide resolved
Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml
Outdated
Show resolved
Hide resolved
Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml
Outdated
Show resolved
Hide resolved
Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml
Outdated
Show resolved
Hide resolved
Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.py
Outdated
Show resolved
Hide resolved
| isfetch: true | ||
| subtype: python3 | ||
| runonce: false |
| fromversion: 6.5.0 | ||
| tests: | ||
| - No tests (auto formatted) | ||
| defaultmapperin: Recorded Future ASI - Incoming Mapper |
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
…dFutureASI.py Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
…dFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
…dFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
…dFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
…dFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
| return_error('Please provide a valid API token') | ||
| project_id = params.get("credential_projectid", {}).get("password") or params.get("project_id") | ||
| if not project_id: | ||
| return_error('Please provide a valid Project ID') |
There was a problem hiding this comment.
Please make the credentials entry one entry in the credentials vault where the project_id is the username and the apikey is the password. While still allowing the old way of authenticating where both project_id and apikey is a secret. Reach out in slack @NicCas if you have any questions
Combined credentials into a single username/password Updated docker image
…ontrib/content into pr/xsoar-bot/30474
…ontrib/content into pr/xsoar-bot/30474
sapirshuker
added
pending-demo
… into NicCas-contrib-RecordedFutureASI
… into NicCas-contrib-RecordedFutureASI
… into NicCas-contrib-RecordedFutureASI
…-RecordedFutureASI' of github.com:xsoar-contrib/content into pr/xsoar-bot/30474
sapirshuker
added
the
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6841074 |
sapirshuker
added
ready-for-instance-test
sapirshuker
approved these changes
Nov 9, 2023
sapirshuker
merged commit 630ff18
into
demisto:contrib/xsoar-contrib_NicCas-contrib-RecordedFutureASI
27 of 29 checks passed
Merged
3 tasks
sapirshuker
added a commit
that referenced
this pull request
Nov 12, 2023
…e - Content Pack Update (#30780) * [Marketplace Contribution] Recorded Future Attack Surface Intelligence - Content Pack Update (#30474) * "contribution update to pack "Recorded Future Attack Surface Intelligence"" * Added 'hidden: true' to encrypted * Added periods to match formatting requirements * Update Packs/RecordedFutureASI/ReleaseNotes/2_1_0.md Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.py Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Updated version number * Added 'defaultmapperin' back * Rename 2_1_0.md to 2.0.10.md * Made suggested formatting changes * Combined credentials into one, updated docker image Combined credentials into a single username/password Updated docker image * Updated to single credential * Changed username to identifier * fixed param username/password * Switched API Key to only credential * Now supports project_id as type 4 and api_key as solo type 9 parameter * add tests,change readme * revert runonce: false on yml * fix tests * Update README.md * remove Incidents Fetch Interval * Update 2.0.10.md * Update 2.0.10.md * Update pack_metadata.json * Update pack_metadata.json * metadata * Update docker image * Update docker image * rename RN from 2.0.10 to 2_0_10 --------- Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com> * fix imports --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
sapirshuker
added a commit
that referenced
this pull request
Dec 21, 2023
…e - Content Pack Update (#30780) * [Marketplace Contribution] Recorded Future Attack Surface Intelligence - Content Pack Update (#30474) * "contribution update to pack "Recorded Future Attack Surface Intelligence"" * Added 'hidden: true' to encrypted * Added periods to match formatting requirements * Update Packs/RecordedFutureASI/ReleaseNotes/2_1_0.md Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.py Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/RecordedFutureASI/Integrations/RecordedFutureASI/RecordedFutureASI.yml Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Updated version number * Added 'defaultmapperin' back * Rename 2_1_0.md to 2.0.10.md * Made suggested formatting changes * Combined credentials into one, updated docker image Combined credentials into a single username/password Updated docker image * Updated to single credential * Changed username to identifier * fixed param username/password * Switched API Key to only credential * Now supports project_id as type 4 and api_key as solo type 9 parameter * add tests,change readme * revert runonce: false on yml * fix tests * Update README.md * remove Incidents Fetch Interval * Update 2.0.10.md * Update 2.0.10.md * Update pack_metadata.json * Update pack_metadata.json * metadata * Update docker image * Update docker image * rename RN from 2.0.10 to 2_0_10 --------- Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com> * fix imports --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com> Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Contributor
@NicCas
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.