Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Netskope v2 - Content Pack Update #30476

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@NicCas

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Oct 26, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_NicCas-contrib-NetskopeV2 October 26, 2023 17:20
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @MosheEichler will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

Copy link
Contributor

@MosheEichler MosheEichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NicCas,
Thank you for your contribution!
Good work :)

Please see my comments,

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again.

Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.yml Outdated Show resolved Hide resolved
Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.py Outdated Show resolved Hide resolved
Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.yml Outdated Show resolved Hide resolved
Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.py Outdated Show resolved Hide resolved
Packs/NetskopeV2/pack_metadata.json Outdated Show resolved Hide resolved
Packs/NetskopeV2/ReleaseNotes/1_1_0.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the file name to 1_0_2.md

@MosheEichler MosheEichler added the pending-contributor The PR is pending the response of its creator label Oct 27, 2023
NicCas and others added 8 commits October 27, 2023 08:34
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
@MosheEichler MosheEichler merged commit 23d1103 into demisto:contrib/xsoar-contrib_NicCas-contrib-NetskopeV2 Oct 28, 2023
18 of 20 checks passed
MosheEichler added a commit that referenced this pull request Oct 29, 2023
* [Marketplace Contribution] Netskope v2 - Content Pack Update (#30476)

* "contribution update to pack "Netskope v2""

* Added 'hidden: true' to encrypted parameter

* Added periods to match formatting requirements

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.yml

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.py

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.yml

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.py

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/pack_metadata.json

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/ReleaseNotes/1_1_0.md

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Rename 1_1_0.md to 1_0_2.md

---------

Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* RN

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* [Marketplace Contribution] Netskope v2 - Content Pack Update (#30476)

* "contribution update to pack "Netskope v2""

* Added 'hidden: true' to encrypted parameter

* Added periods to match formatting requirements

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.yml

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.py

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.yml

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/Integrations/NetskopeV2/NetskopeV2.py

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/pack_metadata.json

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Update Packs/NetskopeV2/ReleaseNotes/1_1_0.md

Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* Rename 1_1_0.md to 1_0_2.md

---------

Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>

* RN

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Moshe Eichler <78307768+MosheEichler@users.noreply.github.com>
Co-authored-by: MosheEichler <meichler@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator
Projects
None yet
4 participants