Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Recorded Future Intelligence - Content Pack Update #30603

Merged
merged 3 commits into from Nov 5, 2023

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Warning
The changes in the contributed files were not made on the most updated pack versions

Item Name Contribution Pack Version Latest Pack Version
Recorded Future v2 1.7.2 1.7.3

For the Reviewer:

  1. Compare the code of this PR with the latest version of the pack. Make sure you understand the changes the contributor intended to contribute, and solve the conflicts accordingly.
  2. In case improvements are needed, instruct the contributor to edit the code through the GitHub Codespaces and Not through the XSOAR UI.

For the Contributor:
@NicCas
In case you are requested by your reviewer to improve the code or to make changes, submit them through the GitHub Codespaces and Not through the XSOAR UI.

To use the GitHub Codespaces, do the following:

  1. Click the 'Code' button in the right upper corner of this PR.
  2. Click 'Create codespace on Transformers'.
  3. Click 'Authorize and continue'.
  4. Wait until your Codespace environment is generated. When it is, you can edit your code.
  5. Commit and push your changes to the head branch of the PR.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@NicCas

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

…k Update (#30475)

* "contribution update to pack "Recorded Future Intelligence""

* Added 'hidden: true' to encrypted parameter

* Fixed formatting

* Reverted defaultmapper and defaultclassifier

* Update version number

* Rename 1_8_0.md to 1.7.4.md

---------

Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved labels Nov 1, 2023
@ilappe ilappe merged commit 638cc8a into master Nov 5, 2023
19 of 20 checks passed
@ilappe ilappe deleted the contrib/xsoar-contrib_NicCas-contrib-RecordedFuture branch November 5, 2023 07:49
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
…k Update (#30603)

* [Marketplace Contribution] Recorded Future Intelligence - Content Pack Update (#30475)

* "contribution update to pack "Recorded Future Intelligence""

* Added 'hidden: true' to encrypted parameter

* Fixed formatting

* Reverted defaultmapper and defaultclassifier

* Update version number

* Rename 1_8_0.md to 1.7.4.md

---------

Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>

* fix RN file name

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Nicole Casartelli <npcasartelli@gmail.com>
Co-authored-by: Israel Lappe <79846863+ilappe@users.noreply.github.com>
Co-authored-by: ilappe <ilappe@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner-Approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
3 participants