Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cisco-amp-event-list command [AMP v2] #30617

Merged
merged 30 commits into from Nov 13, 2023
Merged

Fix cisco-amp-event-list command [AMP v2] #30617

merged 30 commits into from Nov 13, 2023

Conversation

israelpoli
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-29745

Must have

  • Tests
  • Documentation

Copy link
Contributor

@yuvalbenshalom yuvalbenshalom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please just validate the create relationships parameter/argument design

@israelpoli israelpoli merged commit 043bb53 into master Nov 13, 2023
20 of 21 checks passed
@israelpoli israelpoli deleted the fix_AMP_v2_bug branch November 13, 2023 21:34
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Fix cisco-amp-event-list command [AMP v2]

* update RN and README file

* typing

* fix mypy

* add to UT and add parameter Create relationships

* fix mypy

* commit

* Improving the functionality of the fetch_incidents

* fix UT

* commit

* update Docker

* update RN

* commit

* commit

* commit

* fix mypy

* fix pre-commit

* commit

* Add 3 UT for fetch_incidents command

* fix pre-commit

* fix ut

* fix UT

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants