Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] EXAPNDR-6427 Adding delete context changes #30627

Merged
merged 3 commits into from Nov 6, 2023
Merged

[ASM] EXAPNDR-6427 Adding delete context changes #30627

merged 3 commits into from Nov 6, 2023

Conversation

capanw
Copy link
Contributor

@capanw capanw commented Nov 2, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6427

Description

Adding DeleteContext at the start of the playbook.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Nov 2, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_EXPANDR-6427 November 2, 2023 05:30
@capanw capanw marked this pull request as draft November 2, 2023 05:30
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @sapirshuker will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @capanw, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@capanw
Copy link
Contributor Author

capanw commented Nov 2, 2023

@johnnywilkes @BigEasyJ, Can you guys please review. Thank you

johnnywilkes
johnnywilkes suggested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , looks good. See my slack comment about adding to .packs-ignore for the validation. Also, please update the playbook README via SDK (so it includes DeleteContext script). After that we should be GTG

@capanw
Copy link
Contributor Author

capanw commented Nov 2, 2023

@johnnywilkes Thanks for the suggestions - Updated the pack ignore and readme.

@capanw capanw marked this pull request as ready for review November 2, 2023 16:03
johnnywilkes
johnnywilkes approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , approved. You can let XSOAR reviewers to know to merge when possible

@capanw
Copy link
Contributor Author

capanw commented Nov 2, 2023

@melamedbn @sapirshuker Approved from our side. Can you guys review and merge. Thanks

@sapirshuker sapirshuker added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Nov 2, 2023
@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/6777762

@melamedbn melamedbn removed their request for review November 5, 2023 14:17
@sapirshuker sapirshuker merged commit e46a197 into demisto:contrib/PaloAltoNetworks_EXPANDR-6427 Nov 6, 2023
22 of 24 checks passed
@content-bot content-bot mentioned this pull request Nov 6, 2023
Merged
5 tasks
sapirshuker added a commit that referenced this pull request Nov 7, 2023
@content-bot @capanw
@sapirshuker @ShirleyDenkberg
[ASM] EXAPNDR-6427 Adding delete context changes (#30696)
42d6ea8 
* [ASM] EXAPNDR-6427 Adding delete context changes (#30627)

* adding delete context changes

* ignoreing pb105

* readme updates

* Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
sapirshuker added a commit that referenced this pull request Dec 21, 2023
@content-bot @capanw
@sapirshuker @ShirleyDenkberg
[ASM] EXAPNDR-6427 Adding delete context changes (#30696)
d0f0174 
* [ASM] EXAPNDR-6427 Adding delete context changes (#30627)

* adding delete context changes

* ignoreing pb105

* readme updates

* Update Packs/CortexAttackSurfaceManagement/Playbooks/Cortex_ASM_-_ASM_Alert.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

---------

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnywilkes johnnywilkes johnnywilkes approved these changes

@sapirshuker sapirshuker sapirshuker approved these changes

Assignees

@melamedbn melamedbn

@sapirshuker sapirshuker

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
5 participants
@capanw @content-bot @johnnywilkes @sapirshuker @melamedbn