[CSP] Lookback: continue to use lookback even if offest is set #30651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovpraisler
approved these changes
Nov 5, 2023
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://jira-dc.paloaltonetworks.com/browse/XSUP-29572
When offset introduced, I added a check that if offset is being used - we should not use lookback in our queries so the query will use the same timestamp as in the previous fetch.
However, the time that is saved in the last run is the time without the lookback, so we do need to use the lookback anyway to query in the same time.