New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAN-OS] Add the capability to export a TSF #30717
Merged
DeanArbel
merged 11 commits into
master
from
contrib/ali-sawyer_pan-os-support-file-download
Nov 13, 2023
Merged
[PAN-OS] Add the capability to export a TSF #30717
DeanArbel
merged 11 commits into
master
from
contrib/ali-sawyer_pan-os-support-file-download
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add capability to export a TSF from PAN-OS * Initial changes from code review * Add new commands for TSF export instead of modifying the generic pan-os command * change pan-os-export-tech-support-file to single command * incorporate latest review changes * update arguments I missed on the last commit * Fix integration ID Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Fix integration name Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * implement review suggestion * update pack_metadata and release notes * update docker image and fix linting error * remove 'polling' arg and playbook since it is no longer needed * fix release notes and integration YML id/name * pre-commit change * remove whitespace after 'reference-and-research' * Remove print of "Starting TSF export..." Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * add outputs_prefix that was missing from CommandResults * change polling interval to 30s and remove context outputs from command * increment pack version to fix conflict * update RNs Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * update README and RNs * increment version number * update docker image * incorporate review feedback * change to dict_safe_get() Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com> * change to dict_safe_get() Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com> --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
content-bot
added
Contribution
Thank you! Contributions are always welcome!
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
post-demo
Contribution Form Filled
Whether contribution form filled or not.
Community
pending-contributor
The PR is pending the response of its creator
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Internal PR
Security Review
labels
Nov 7, 2023
…pan-os-support-file-download
MichaelYochpaz
approved these changes
Nov 8, 2023
Requires a force-merge due to failing test-playbook. |
DeanArbel
deleted the
contrib/ali-sawyer_pan-os-support-file-download
branch
November 13, 2023 08:08
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* [PAN-OS] Add the capability to export a TSF (#29564) * add capability to export a TSF from PAN-OS * Initial changes from code review * Add new commands for TSF export instead of modifying the generic pan-os command * change pan-os-export-tech-support-file to single command * incorporate latest review changes * update arguments I missed on the last commit * Fix integration ID Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * Fix integration name Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> * implement review suggestion * update pack_metadata and release notes * update docker image and fix linting error * remove 'polling' arg and playbook since it is no longer needed * fix release notes and integration YML id/name * pre-commit change * remove whitespace after 'reference-and-research' * Remove print of "Starting TSF export..." Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * add outputs_prefix that was missing from CommandResults * change polling interval to 30s and remove context outputs from command * increment pack version to fix conflict * update RNs Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * update README and RNs * increment version number * update docker image * incorporate review feedback * change to dict_safe_get() Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com> * change to dict_safe_get() Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com> --------- Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com> * Bump Docker version * Fixes --------- Co-authored-by: Ali Sawyer <91506078+ali-sawyer@users.noreply.github.com> Co-authored-by: Michael Yochpaz <8832013+MichaelYochpaz@users.noreply.github.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: Jacob Levy <129657918+jlevypaloalto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Contribution Form Filled
Whether contribution form filled or not.
Contribution
Thank you! Contributions are always welcome!
docs-approved
ForceMerge
Internal PR
pending-contributor
The PR is pending the response of its creator
post-demo
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Security Review
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@ali-sawyer
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
N/A
Description
Add the capability to automatically export a tech support file (TSF) from PAN-OS.
Must have