Fix armis get events command #30877
Merged
Fix armis get events command #30877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AQL arg
update RN update README
…isto/content into fix_armis_get_events_command
DeanArbel
approved these changes
Nov 22, 2023
Packs/Armis/Integrations/ArmisEventCollector/ArmisEventCollector.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Fixing armis-get-events * Adjust unit test to changes. * handle armis-get-events if no events return * restore-alerts-parsing-rule * update-release-notes * update-release-notes * Fix eventType is missing error * Fix unit tests. Add AQL arg * bump docker version. update RN update README * Add unitest increase coverage * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * pre-commit failures --------- Co-authored-by: Chanan Welt <cwelt@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Description
Fixes the command armis-get-events, add to it an event type argument