Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadPDFFileV2 add support for owner password #30927

Merged
merged 13 commits into from Nov 16, 2023

Conversation

anas-yousef
Copy link
Contributor

@anas-yousef anas-yousef commented Nov 15, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-30094

Description

Added a fix where the pdfinfo command line would only open files using a user password, it now supports opening the file using an owner password.

Related Confluence Page

https://confluence-dc.paloaltonetworks.com/display/DemistoContent/ReadPDFFileV2

Must have

  • Tests
  • Documentation

@anas-yousef anas-yousef self-assigned this Nov 15, 2023
@anas-yousef anas-yousef changed the title Added support for owner password ReadPDFFileV2 add support for owner password Nov 15, 2023
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good job!
Please check my comments.

Packs/CommonScripts/ReleaseNotes/1_12_43.md Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/ReadPDFFileV2/ReadPDFFileV2.py Outdated Show resolved Hide resolved
anas-yousef and others added 8 commits November 16, 2023 09:46
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Copy link
Contributor

@JasBeilin JasBeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@anas-yousef anas-yousef merged commit 76a1942 into master Nov 16, 2023
20 checks passed
@anas-yousef anas-yousef deleted the ay-read-pdf-file-password-bug branch November 16, 2023 09:40
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Added support for owner password

* Removed unnecessary imports

* Updated RNs

* Update Packs/CommonScripts/ReleaseNotes/1_12_43.md

* Fixed CR

---------

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants