Contrib/binalyze air update #30950
Merged
Contrib/binalyze air update #30950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Acquisition profiles extended to manual created ones. Organization_id vale type bug fixed. Minor changes in README.md file. * Acquisition profiles extended to manual created ones. Organization_id vale type bug fixed. Minor changes in README.md file. * Acquisition profiles extended to manual created ones. Organization_id vale type bug fixed. Minor changes in README.md file. * Docker version updated * Unrelated line deleted. * Acquisition profile changed. arg_to_number is used for type change. * organization id type check changed from str to any in both commands. * Get profile_id function created under Client class. Data type check moved under class's functions. * Test profile id added. * profile id added to the command test coverage. * New_line addressed: https://app.circleci.com/pipelines/github/demisto/content/309467/workflows/b6a8cb09-0e6b-4ea7-a1e9-2650ac98a978/jobs/724183?invite=true#step-120-7123_48 * Conflict resolved * Conflict resolved * Suggestion accepted. * Versioning fixed. * - Get profile id changed: preset values does not have id, so it needs to pbe passed as is. - Arg_to_number moved to the commands section as advised. * - Resolves https://app.circleci.com/pipelines/github/demisto/content/310327/workflows/c343f258-6e56-4098-a697-345d30ba452a/jobs/724633/parallel-runs/0/steps/0-119 * - str to any. * Rolled back the changes because of the comments, test suite(mypy) yells at me. * Type change is alligned with reviewer. * Predefined settings have changed. * revert RN change * This resolves #30161 (comment) * LAst comments fixed. * Reverted to predefined. Added more Org is * Custom profile command example added. * Documentation updated. * Get profile id test case added. * docker image update * docker image update * Context path junk string purged. * Update Packs/Binalyze/Integrations/BinalyzeAIR/BinalyzeAIR_test.py Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Update Packs/Binalyze/Integrations/BinalyzeAIR/BinalyzeAIR_test.py Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com> * Whitespaces cleaned. * Last review's issues addressed. * add predfined description * Minor changes on descriptions. * Demo review implemented. * Demo review implemented. * Error handling removed. * Test case fixed. * Test case minor change. * Test case minor change. * Test case minor change. * Newline and typo * Update BinalyzeAIR_test.py --------- Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com> Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
content-bot
added
Contribution
sapirshuker
approved these changes
Nov 16, 2023
sapirshuker
deleted the
contrib/binalyze-murat_contrib/binalyze-air-update
branch
sapirshuker
added a commit
that referenced
this pull request
Dec 21, 2023
* Acquisition profiles extended to manual created ones. Organization_id vale type bug fixed. Minor changes in README.md file. * Acquisition profiles extended to manual created ones. Organization_id vale type bug fixed. Minor changes in README.md file. * Acquisition profiles extended to manual created ones. Organization_id vale type bug fixed. Minor changes in README.md file. * Docker version updated * Unrelated line deleted. * Acquisition profile changed. arg_to_number is used for type change. * organization id type check changed from str to any in both commands. * Get profile_id function created under Client class. Data type check moved under class's functions. * Test profile id added. * profile id added to the command test coverage. * New_line addressed: https://app.circleci.com/pipelines/github/demisto/content/309467/workflows/b6a8cb09-0e6b-4ea7-a1e9-2650ac98a978/jobs/724183?invite=true#step-120-7123_48 * Conflict resolved * Conflict resolved * Suggestion accepted. * Versioning fixed. * - Get profile id changed: preset values does not have id, so it needs to pbe passed as is. - Arg_to_number moved to the commands section as advised. * - Resolves https://app.circleci.com/pipelines/github/demisto/content/310327/workflows/c343f258-6e56-4098-a697-345d30ba452a/jobs/724633/parallel-runs/0/steps/0-119 * - str to any. * Rolled back the changes because of the comments, test suite(mypy) yells at me. * Type change is alligned with reviewer. * Predefined settings have changed. * revert RN change * This resolves #30161 (comment) * LAst comments fixed. * Reverted to predefined. Added more Org is * Custom profile command example added. * Documentation updated. * Get profile id test case added. * docker image update * docker image update * Context path junk string purged. * Update Packs/Binalyze/Integrations/BinalyzeAIR/BinalyzeAIR_test.py * Update Packs/Binalyze/Integrations/BinalyzeAIR/BinalyzeAIR_test.py * Whitespaces cleaned. * Last review's issues addressed. * add predfined description * Minor changes on descriptions. * Demo review implemented. * Demo review implemented. * Error handling removed. * Test case fixed. * Test case minor change. * Test case minor change. * Test case minor change. * Newline and typo * Update BinalyzeAIR_test.py --------- Co-authored-by: binalyze-murat <106888581+binalyze-murat@users.noreply.github.com> Co-authored-by: sapirshuker <sshuker@paloaltonetworks.com> Co-authored-by: Sapir Shuker <49246861+sapirshuker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@binalyze-murat
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
This is a minor upgrade upon a customer's request. Organization_id data type changes strictly to int, and acquisition profile usage has changed.
Must have