Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get incident task by state add loop error #31012

Merged
merged 6 commits into from Nov 22, 2023

Conversation

ShahafBenYakir
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CRTX-98021

Description

Added support to show failing tasks with an error of loopError

@@ -37,8 +38,12 @@ function getAllPlaybookTasks(tasks) {
}

function getStates(states) {
var input_states = states.split(",");
if (input_states.includes('error')) {
input_states = input_states.concat('loopError')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's concat? isnt inputstates a list?

nevermind its js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Packs/DemistoRESTAPI/ReleaseNotes/1_3_38.md Outdated Show resolved Hide resolved
@ShahafBenYakir
Copy link
Contributor Author

Gitlab is failing on:

  • xsoar ng tests, known issue build on call is investigating.
  • missing test pb
    Force merging

@ShahafBenYakir ShahafBenYakir merged commit b3a2306 into master Nov 22, 2023
18 of 20 checks passed
@ShahafBenYakir ShahafBenYakir deleted the GetIncidentTaskByState_-_add_loopError branch November 22, 2023 14:32
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Added support for looperror

* Added rn

* Update Packs/DemistoRESTAPI/ReleaseNotes/1_3_38.md

* Formatted yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants