Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carriage return issue in get list row #31020

Merged
merged 14 commits into from Nov 22, 2023

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Nov 21, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: XSUP-30548

Description

Fix carriage return issue in get list row.
Link to the test failure before the fix: https://github.com/demisto/content/assets/70104171/5dc95f0d-3a2f-4341-9794-76bc5a63b819)

Screenshot 2023-11-21 at 17 07 42

Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.12.46.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@YuvHayun YuvHayun merged commit c9f362d into master Nov 22, 2023
17 checks passed
@YuvHayun YuvHayun deleted the fix_carriage_return_issue_in_GetListRow branch November 22, 2023 18:49
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* add fix and unit test

* added rn

* revert fix

* fixes added back

* fixes

* update docker

* Bump pack from version CommonScripts to 1.12.46.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: JudithB <132264628+jbabazadeh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants