[Azure Sentinel] Fix first fetch #31058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvalbenshalom
suggested changes
Nov 22, 2023
|
|
||
| if not raw_incidents: | ||
| # if we don't have any raw incidents, we want to keep the last incident id and update the last_created_time to now | ||
| latest_created_time = datetime.utcnow() |
There was a problem hiding this comment.
if last created time exists(so it is not 0) shouldn't we just preserve it and not override it with now?
There was a problem hiding this comment.
You right, we can keep the old time.
The latest_created_time always exist so we can delete this line.
The only change is to continue to fetch by timestamp if the latest incident number is 0.
yuvalbenshalom
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-29015
Description
last_incident_numberis 0 or None, beacuse it means that no incidents were fetched.