Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dbot closed incidents percentage script #31093

Merged
merged 9 commits into from Nov 26, 2023
Merged

Fix dbot closed incidents percentage script #31093

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eb5c073
Fixed DBotClosedIncidentsPercentage script query
MosheEichler Nov 23, 2023
c4621d8
RN
MosheEichler Nov 23, 2023
008fe8b
Merge branch 'master' into fix-DBotClosedIncidentsPercetage-script
MosheEichler Nov 23, 2023
97db587
format
MosheEichler Nov 23, 2023
a55ba9b
RN
MosheEichler Nov 23, 2023
5cfcb36
Update Packs/CommonScripts/ReleaseNotes/1_12_47.md
MosheEichler Nov 24, 2023
4901845
Merge branch 'master' into fix-DBotClosedIncidentsPercetage-script
MosheEichler Nov 24, 2023
97a70c5
Merged master into current branch.
Nov 26, 2023
1a84547
Bump pack from version CommonScripts to 1.12.48.
Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions Packs/CommonScripts/ReleaseNotes/1_12_47.md
View file
Open in desktop
@@ -0,0 +1,6 @@

#### Scripts

##### DBotClosedIncidentsPercentage

Updated the query in the**DBotClosedIncidentsPercentage** script to `status:closed and closingUser:DBot`.
2 changes: 1 addition & 1 deletion Packs/CommonScripts/Scripts/DBotClosedIncidentsPercentage/DBotClosedIncidentsPercentage.js
View file
Open in desktop
@@ -1,5 +1,5 @@
var res = executeCommand("getIncidents", {
'query': 'status:closed and investigation.users:""',
'query': 'status:closed and closingUser:DBot',
'fromdate': args.from,
'todate': args.to,
'size': 0
Expand Down
2 changes: 1 addition & 1 deletion Packs/CommonScripts/Scripts/DBotClosedIncidentsPercentage/DBotClosedIncidentsPercentage.yml
View file
Open in desktop
@@ -1,4 +1,4 @@
commonfields:

Check failure on line 1 in Packs/CommonScripts/Scripts/DBotClosedIncidentsPercentage/DBotClosedIncidentsPercentage.yml

View workflow job for this annotation

GitHub Actions / pre-commit

Validation Error CJ105 

Either DBotClosedIncidentsPercentage does not have any test playbooks or that all test playbooks in this pack are currently skipped, and there is no unittests file to be found.
Please create a test playbook or un-skip at least one of the relevant test playbooks.
 You can un-skip a playbook by deleting the line relevant to one of the test playbooks from the 'skipped_tests' section inside the conf.json file and deal with the matching issue,
  or create a new active test playbook and add the id to the 'tests' field in the yml.
id: DBotClosedIncidentsPercentage
version: -1
name: DBotClosedIncidentsPercentage
Expand All @@ -6,7 +6,7 @@
type: javascript
tags:
- widget
comment: Data output script for populating dashboard pie graph widget with the percentage of incidents closed by DBot vs. incidents closed by analysts
comment: Data output script for populating dashboard pie graph widget with the percentage of incidents closed by DBot vs. incidents closed by analysts.
enabled: true
scripttarget: 0
runas: DBotRole
Expand Down
2 changes: 1 addition & 1 deletion Packs/CommonScripts/pack_metadata.json
View file
Open in desktop
Expand Up @@ -2,7 +2,7 @@
"name": "Common Scripts",
"description": "Frequently used scripts pack.",
"support": "xsoar",
"currentVersion": "1.12.46",
"currentVersion": "1.12.47",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down