Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] QR Code Read and Decode (offline) #31099

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@johestephan

Description

The automation reads and decodes QR codes from file. It uses the demisto/opencv docker container and works completly offline

Auto-Generated Documentation Requiring Modification

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Nov 23, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_johestephan-contrib-QRCodeReadAndDecode_Offline November 23, 2023 16:54
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @adi88d will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@adi88d
Copy link
Contributor

adi88d commented Nov 27, 2023

Hi @johestephan and thank you for your contribution!
We already have a pack with the name QR Code Reader that has integration to read QR Code from image file, I tested it now using this QR:

image

that should link to :
https://www.google.com/

image

can you please check this pack and tell me if the automation you wrote do the same?
thanks

@adi88d adi88d added the pending-contributor The PR is pending the response of its creator label Nov 27, 2023
@johestephan
Copy link
Contributor

johestephan commented Nov 28, 2023 via email

@adi88d
Copy link
Contributor

adi88d commented Nov 28, 2023

Hi @johestephan I just tested your script with the QR code for https://www.google.com/ and it didnt find anything:
image
Please check it

@johestephan
Copy link
Contributor

johestephan commented Nov 29, 2023 via email

@adi88d
Copy link
Contributor

adi88d commented Dec 3, 2023

@johestephan did you find the issue in the script?

@adi88d adi88d merged commit 0a0a7d3 into demisto:contrib/xsoar-contrib_johestephan-contrib-QRCodeReadAndDecode_Offline Dec 17, 2023
10 of 20 checks passed
adi88d added a commit that referenced this pull request Dec 17, 2023
* [Marketplace Contribution] QR Code Read and Decode (offline) (#31099)

* "pack contribution initial commit"

* Update Qrcodereader.py

fixed for Multi

* move script to QRCodeReader pack

* format yml file

* update RN

* add CONTRIBUTORS.json
fix flake8

---------

Co-authored-by: Joerg Stephan <7138386+johestephan@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

* add disable=no-member

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Joerg Stephan <7138386+johestephan@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* [Marketplace Contribution] QR Code Read and Decode (offline) (#31099)

* "pack contribution initial commit"

* Update Qrcodereader.py

fixed for Multi

* move script to QRCodeReader pack

* format yml file

* update RN

* add CONTRIBUTORS.json
fix flake8

---------

Co-authored-by: Joerg Stephan <7138386+johestephan@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

* add disable=no-member

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Joerg Stephan <7138386+johestephan@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* [Marketplace Contribution] QR Code Read and Decode (offline) (#31099)

* "pack contribution initial commit"

* Update Qrcodereader.py

fixed for Multi

* move script to QRCodeReader pack

* format yml file

* update RN

* add CONTRIBUTORS.json
fix flake8

---------

Co-authored-by: Joerg Stephan <7138386+johestephan@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

* add disable=no-member

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: Joerg Stephan <7138386+johestephan@users.noreply.github.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator
Projects
None yet
4 participants