Added context output and indicator tagging to CreateIndicatorsFromStix #31140

mohlcyber · 2023-11-27T14:27:38Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Description

Added argument context argument for context output to !CreateIndicatorsFromSTIX
Added argument tags argument for indicator tagging to !CreateIndicatorsFromSTIX

Must have

Tests
Documentation

Bumped Up Version to 1.12.50

content-bot · 2023-11-27T14:29:27Z

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @adi88d will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

content-bot · 2023-11-27T14:29:27Z

Hi @mohlcyber, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

…mSTIX' into contrib-mohlcyber-CreateIndicatorsFromSTIX

adi88d

Great Job!
Thanks a lot for this contribution, It is highly appreciated.
I added some review comments and suggestion:

Please fix the failed tests in CreateIndicatorsFromSTIX_test.py file.
Add to the file also tests for create_indicators_loop method to check the results with/ without context and tags arguments.
see my other comments below

Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml

Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.py

Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml

Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.py

Packs/CommonScripts/ReleaseNotes/1_12_50.md

adi88d · 2023-12-03T12:27:50Z

Hi @mohlcyber , we haven’t heard from you in a while.
Do you need any help with the pull request?

Please feel free to reach out to me here or on Slack.
Thanks again for contributing to our repo, hope to hear from you soon.

Update Fork

…icatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

…icatorsFromSTIX.yml Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

…icatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

Added additional asserts in test

Update Master

# Conflicts: # Packs/CommonScripts/ReleaseNotes/1_12_56.md # Packs/CommonScripts/pack_metadata.json

Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml

Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/README.md

ShirleyDenkberg · 2023-12-14T12:39:37Z

@adi88d Doc review completed.

…icatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

adi88d

Nice job!

#31485) * Added context output and indicator tagging to CreateIndicatorsFromStix (#31140) * Added context output and tagging to CreateIndicatorsFromSTIX.py * Removed Spaces in CommandResults * Added Release Note Bumped Up Version to 1.12.50 * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> * Update Packs/CommonScripts/ReleaseNotes/1_12_50.md Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> * fixes in CreateIndicatorsFromSTIX.py * Updated YML * Updated CreateIndicatorsFromSTIX_test.py * Updated CreateIndicatorsFromSTIX_test.py * Updated Docker Image Version * Updated Release notes to align with docker version * Added Tags to context output. * Added outputs to CreateIndicatorsFromSTIX.yml * Bumped up Docker Image version in Release Note and YML Added additional asserts in test * Adjusted Version * Updated README.md * Updated CreateIndicatorsFromSTIX.yml with description periods. * Added CONTRIBUTORS.json * Deleted CONTRIBUTORS.json * Update 1_13_5.md * Update CreateIndicatorsFromSTIX.yml * Update README.md * Update README.md * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateIndicatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> --------- Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * merge from master --------- Co-authored-by: Martin Ohl <Martin.Ohl@ohl-net.eu> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: adi88d <adaud@paloaltonetworks.com>

mohlcyber added 3 commits November 27, 2023 13:42

Added context output and tagging to CreateIndicatorsFromSTIX.py

db1fcb8

Removed Spaces in CommandResults

871eff6

Added Release Note

b103f8d

Bumped Up Version to 1.12.50

content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Nov 27, 2023

content-bot changed the base branch from master to contrib/mohlcyber_contrib-mohlcyber-CreateIndicatorsFromSTIX November 27, 2023 14:29

content-bot assigned adi88d Nov 27, 2023

content-bot requested a review from adi88d November 27, 2023 14:29

Merge branch 'contrib/mohlcyber_contrib-mohlcyber-CreateIndicatorsFro…

d17424c

…mSTIX' into contrib-mohlcyber-CreateIndicatorsFromSTIX

adi88d requested changes Nov 28, 2023

View reviewed changes

adi88d added the pending-contributor The PR is pending the response of its creator label Nov 28, 2023

mohlcyber and others added 13 commits December 7, 2023 10:40

Merge pull request #1 from demisto/master

e6a3024

Update Fork

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

c448a86

…icatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

b80d81c

…icatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

c8c21b8

…icatorsFromSTIX.yml Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

Update Packs/CommonScripts/ReleaseNotes/1_12_50.md

68919eb

Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

e6f9a01

…icatorsFromSTIX.py Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>

fixes in CreateIndicatorsFromSTIX.py

5145f4a

Merge with Master and bumped up CommonScripts Version

5f3b296

Updated YML

4652699

Updated CreateIndicatorsFromSTIX_test.py

e24f061

Updated CreateIndicatorsFromSTIX_test.py

f7c0de6

Updated Docker Image Version

41c8cc6

Updated Release notes to align with docker version

d774642

mohlcyber and others added 13 commits December 14, 2023 10:38

Added outputs to CreateIndicatorsFromSTIX.yml

f590192

Bumped up Docker Image version in Release Note and YML

e98ba0e

Added additional asserts in test

Merge pull request #2 from demisto/master

7799b66

Update Master

Merge branch 'master' into contrib-mohlcyber-CreateIndicatorsFromSTIX

25346ea

# Conflicts: # Packs/CommonScripts/ReleaseNotes/1_12_56.md # Packs/CommonScripts/pack_metadata.json

Adjusted Version

8255188

Updated README.md

51cb9a5

Updated CreateIndicatorsFromSTIX.yml with description periods.

0e5df38

Added CONTRIBUTORS.json

d7ae812

Deleted CONTRIBUTORS.json

17bf4c5

Update 1_13_5.md

9f79f79

Update CreateIndicatorsFromSTIX.yml

8c11198

Update README.md

474118c

Update README.md

8fc9b8f

adi88d assigned ShirleyDenkberg Dec 14, 2023

ShirleyDenkberg reviewed Dec 14, 2023

View reviewed changes

ShirleyDenkberg added the docs-approved label Dec 14, 2023

adi88d and others added 5 commits December 14, 2023 14:40

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

ecf96ae

…icatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

9f06a04

…icatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/CreateInd…

b131030

…icatorsFromSTIX.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/README.md

16835bb

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/CommonScripts/Scripts/CreateIndicatorsFromSTIX/README.md

231d145

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

adi88d self-requested a review December 14, 2023 12:41

adi88d approved these changes Dec 14, 2023

View reviewed changes

adi88d merged commit b37d60b into demisto:contrib/mohlcyber_contrib-mohlcyber-CreateIndicatorsFromSTIX Dec 14, 2023
12 of 14 checks passed

content-bot mentioned this pull request Dec 14, 2023

Added context output and indicator tagging to CreateIndicatorsFromStix #31485

Merged

5 tasks

mohlcyber deleted the contrib-mohlcyber-CreateIndicatorsFromSTIX branch February 2, 2024 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added context output and indicator tagging to CreateIndicatorsFromStix #31140

Added context output and indicator tagging to CreateIndicatorsFromStix #31140

mohlcyber commented Nov 27, 2023

content-bot commented Nov 27, 2023

content-bot commented Nov 27, 2023

adi88d left a comment

adi88d commented Dec 3, 2023

ShirleyDenkberg commented Dec 14, 2023

adi88d left a comment

Added context output and indicator tagging to CreateIndicatorsFromStix #31140

Added context output and indicator tagging to CreateIndicatorsFromStix #31140

Conversation

mohlcyber commented Nov 27, 2023

Status

Description

Must have

content-bot commented Nov 27, 2023

content-bot commented Nov 27, 2023

adi88d left a comment

Choose a reason for hiding this comment

adi88d commented Dec 3, 2023

ShirleyDenkberg commented Dec 14, 2023

adi88d left a comment

Choose a reason for hiding this comment