Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExtractEmailTransformer] Convert to JS #31159

Merged
merged 78 commits into from Dec 11, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Nov 28, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Change the ExtractEmailTransformer script to JS.

TPB

ExtractEmailTransformer_Test

mmhw and others added 30 commits November 14, 2023 15:13
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.32.54.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@mmhw mmhw requested a review from DeanArbel December 10, 2023 13:12
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, looks good.

@mmhw
Copy link
Contributor Author

mmhw commented Dec 11, 2023

force mege:
C106 fails due to a rule that prevents increase the fromVersion.

@DeanArbel DeanArbel merged commit 4a6bf06 into master Dec 11, 2023
19 of 22 checks passed
@DeanArbel DeanArbel deleted the MW/CIAC-8741/ExtractEmailTransformer/Convert_to_JS branch December 11, 2023 12:25
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* [transformers] Enhance to be more durable

* Add RN

* Add RN; run format

* Bump pack from version CommonScripts to 1.12.43.

* IsEmailAddressInternal set isArray to true

* Add TPB for SetAndHandleEmpty

* Add TPB for IsEmailAddressInternal

* Bump pack from version CommonScripts to 1.12.44.

* Add TPB for ExtractEmailTransformer

* Update the TPB for SetIfEmpty

* Update the TPB for SetIfEmpty

* Compatibility with XSOAR 6.9.0

* Update Packs/FiltersAndTransformers/Scripts/WhereFieldEquals/WhereFieldEquals.js

* Delete pytest files

* Bump pack from version CommonScripts to 1.12.46.

* Bump pack from version CommonScripts to 1.12.47.

* Bump pack from version CommonScripts to 1.12.48.

* Bump pack from version CommonScripts to 1.12.49.

* Bump pack from version CommonScripts to 1.12.50.

* First commit

* Added RN

* empty

* Test to update emailRegex

* Test to update emailRegex 1

* fix version

* fix RN

* Bump pack from version Base to 1.32.52.

* Fix the regex

* Add two versions: py and JS

* Bump pack from version Base to 1.32.53.

* Split by versions

* Split by versions

* Add ignore from BA109

* Fix the regex

* Bump pack from version Base to 1.32.54.

* Revert

* Revert

* Change the files name

* Update the TPB

* Fix the unit test

* Update the README file

* Add ignore; Update the docker image; Add RN

* Update the docker image

* Fix the conf.json

* Add "pragma: no cover" to main

* Update the TPB

---------

Co-authored-by: Content Bot <bot@demisto.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* [transformers] Enhance to be more durable

* Add RN

* Add RN; run format

* Bump pack from version CommonScripts to 1.12.43.

* IsEmailAddressInternal set isArray to true

* Add TPB for SetAndHandleEmpty

* Add TPB for IsEmailAddressInternal

* Bump pack from version CommonScripts to 1.12.44.

* Add TPB for ExtractEmailTransformer

* Update the TPB for SetIfEmpty

* Update the TPB for SetIfEmpty

* Compatibility with XSOAR 6.9.0

* Update Packs/FiltersAndTransformers/Scripts/WhereFieldEquals/WhereFieldEquals.js

* Delete pytest files

* Bump pack from version CommonScripts to 1.12.46.

* Bump pack from version CommonScripts to 1.12.47.

* Bump pack from version CommonScripts to 1.12.48.

* Bump pack from version CommonScripts to 1.12.49.

* Bump pack from version CommonScripts to 1.12.50.

* First commit

* Added RN

* empty

* Test to update emailRegex

* Test to update emailRegex 1

* fix version

* fix RN

* Bump pack from version Base to 1.32.52.

* Fix the regex

* Add two versions: py and JS

* Bump pack from version Base to 1.32.53.

* Split by versions

* Split by versions

* Add ignore from BA109

* Fix the regex

* Bump pack from version Base to 1.32.54.

* Revert

* Revert

* Change the files name

* Update the TPB

* Fix the unit test

* Update the README file

* Add ignore; Update the docker image; Add RN

* Update the docker image

* Fix the conf.json

* Add "pragma: no cover" to main

* Update the TPB

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants