Added new pack: Email Hippo #31167
Merged
Added new pack: Email Hippo #31167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalgold @DeanArbel @idovandijk Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
|
@ilappe Don't forget to create content for the pack readme. |
…isto/content into ilappe/CIAC-6673/hippo_email
…pe/CIAC-6673/hippo_email
Thanks @ShirleyDenkberg |
|
@ilappe I reviewed the pack readme. One small edit. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…pe/CIAC-6673/hippo_email
…isto/content into ilappe/CIAC-6673/hippo_email
…pe/CIAC-6673/hippo_email
DeanArbel
approved these changes
Dec 5, 2023
Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
…isto/content into ilappe/CIAC-6673/hippo_email
This reverts commit 3c77133.
…isto/content into ilappe/CIAC-6673/hippo_email
…pe/CIAC-6673/hippo_email
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* new pack * Apply suggestions from code review - part 1 Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review - part 2 Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review - part 3 Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/EmailHippo/Integrations/EmailHippo/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/EmailHippo/Integrations/EmailHippo/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * A stricter test * RN for CommonDashboards * test playbook * pack readme * update pack_metadata * Update Packs/EmailHippo/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix test fail * compare dict * Update Packs/EmailHippo/Integrations/EmailHippo/EmailHippo.yml Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> * Update EmailHippo.yml * Update EmailHippo.yml * Revert "compare dict" This reverts commit 13e8fbf55d5989d3dd526c6cf7a9f0e8fca62d91. * update docker * add no cover * fix CR * update the image * fix pre commit --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
* new pack * Apply suggestions from code review - part 1 Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review - part 2 Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Apply suggestions from code review - part 3 Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/EmailHippo/Integrations/EmailHippo/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/EmailHippo/Integrations/EmailHippo/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * A stricter test * RN for CommonDashboards * test playbook * pack readme * update pack_metadata * Update Packs/EmailHippo/README.md Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * fix test fail * compare dict * Update Packs/EmailHippo/Integrations/EmailHippo/EmailHippo.yml Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com> * Update EmailHippo.yml * Update EmailHippo.yml * Revert "compare dict" This reverts commit 13e8fbf55d5989d3dd526c6cf7a9f0e8fca62d91. * update docker * add no cover * fix CR * update the image * fix pre commit --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: Dean Arbel <darbel@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6673
Description
a new pack
Email Hippoincluding:Must have