Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Qradar search PB with the representative command #31328

Merged
merged 19 commits into from Dec 17, 2023

Conversation

ssokolovich
Copy link
Contributor

@ssokolovich ssokolovich commented Dec 6, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-30760

Description

Replaced a deprecated PB with the new Qradar command qradar-search-retrieve-results

Must have

  • Tests
  • Documentation

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonPlaybooks pack version was bumped to 2.4.40.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • QRadar pack version was bumped to 2.4.46.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@@ -134,7 +134,8 @@ tasks:
inplace:
simple: "False"
input:
simple: ${QRadar.Search.Result.events}
complex:
root: QRadar.SearchEvents.Events
input_key:
simple: ${QRadar.Search.Result}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the old output

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please open the ticket for the validation

@ssokolovich ssokolovich merged commit 29995dd into master Dec 17, 2023
21 of 22 checks passed
@ssokolovich ssokolovich deleted the replaceing_qradar_search_pb_with_command branch December 17, 2023 08:07
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* Changed the QradarSearch PB to the relavent command

* RN

* RN

* Changed the PB to be deprecated

* Changed keys according to the new output

* Resolve conflicts

* Removed un required tests

* Changed from simple to complex

* Bump pack from version CommonPlaybooks to 2.4.40.

* Added BC + updated the PB readme files

* Added BC + updated the PB readme files

* Bump pack from version QRadar to 2.4.46.

* removed un-used script arguments ( ChangeContext script)

---------

Co-authored-by: Content Bot <bot@demisto.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* Changed the QradarSearch PB to the relavent command

* RN

* RN

* Changed the PB to be deprecated

* Changed keys according to the new output

* Resolve conflicts

* Removed un required tests

* Changed from simple to complex

* Bump pack from version CommonPlaybooks to 2.4.40.

* Added BC + updated the PB readme files

* Added BC + updated the PB readme files

* Bump pack from version QRadar to 2.4.46.

* removed un-used script arguments ( ChangeContext script)

---------

Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants