New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS Falcon - Add batch_id argument to run_command #31394
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalpalo
approved these changes
Dec 11, 2023
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py
Outdated
Show resolved
Hide resolved
…rikeFalcon.py Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* added batch_id argument * unit tests * updated unit tests and docker image * RN * updated README * Update Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> * Bump pack from version CrowdStrikeFalcon to 1.12.8. * updated the timeout * updated the timeout * updated the timeout * docker image update --------- Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com>
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
* added batch_id argument * unit tests * updated unit tests and docker image * RN * updated README * Update Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> * Bump pack from version CrowdStrikeFalcon to 1.12.8. * updated the timeout * updated the timeout * updated the timeout * docker image update --------- Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com> Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
To fix a bug in which the run_command runs on a different batch each time, I added the option to give a batch_id as an argument, so different run_command executions can be executed on the same batch.
Must have