Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS Falcon - Add batch_id argument to run_command #31394

Merged
merged 16 commits into from Dec 14, 2023

Conversation

RotemAmit
Copy link
Contributor

@RotemAmit RotemAmit commented Dec 11, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

To fix a bug in which the run_command runs on a different batch each time, I added the option to give a batch_id as an argument, so different run_command executions can be executed on the same batch.

Must have

  • Tests
  • Documentation

@RotemAmit RotemAmit marked this pull request as ready for review December 11, 2023 11:21
…rikeFalcon.py

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CrowdStrikeFalcon pack version was bumped to 1.12.8.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@RotemAmit RotemAmit removed the request for review from michal-dagan December 13, 2023 16:55
@RotemAmit RotemAmit merged commit abb3b15 into master Dec 14, 2023
17 of 18 checks passed
@RotemAmit RotemAmit deleted the xsup-31070/cs_falcon_rtr_bug_fix branch December 14, 2023 10:20
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* added batch_id argument

* unit tests

* updated unit tests and docker image

* RN

* updated README

* Update Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>

* Bump pack from version CrowdStrikeFalcon to 1.12.8.

* updated the timeout

* updated the timeout

* updated the timeout

* docker image update

---------

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* added batch_id argument

* unit tests

* updated unit tests and docker image

* RN

* updated README

* Update Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>

* Bump pack from version CrowdStrikeFalcon to 1.12.8.

* updated the timeout

* updated the timeout

* updated the timeout

* docker image update

---------

Co-authored-by: EyalPintzov <91007713+eyalpalo@users.noreply.github.com>
Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants