Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic polling task #31411

Merged
merged 22 commits into from Dec 17, 2023
Merged

Remove generic polling task #31411

merged 22 commits into from Dec 17, 2023

Conversation

karinafishman
Copy link
Contributor

@karinafishman karinafishman commented Dec 12, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9109
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-8740

Description

Removing generic polling task from the playbook. the generic polling implemented as part of the integration.
Azure-DevOps-Pipeline-Run - generic polling task removed
PAN-OS Commit Configuration - the old version was deprecated and new version created

Force merged because of the ticket: https://jira-dc.paloaltonetworks.com/browse/CIAC-9115

Must have

  • Tests
  • Documentation

@ShirleyDenkberg
Copy link
Contributor

@ssokolovich Doc review completed.

Copy link
Contributor Author

@karinafishman karinafishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shirley's fixes

Copy link
Contributor

@ssokolovich ssokolovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DeanArbel DeanArbel merged commit dc11976 into master Dec 17, 2023
15 of 17 checks passed
@DeanArbel DeanArbel deleted the Remove-generic-polling-task branch December 17, 2023 11:56
tkatzir pushed a commit that referenced this pull request Dec 20, 2023
* generic polling task was removed and read me file created

* Release notes update

* release notes update

* old playbook deprecated and new version created

* release notes added

* added image to the old playbook version

* deprecated for the playbook

* RN updated

* added image

* removed unnecessary tasks

* added more outputs

* RN updated

* added description

* image replaced

* added an instance to a test PB

* removed tests instances
removed from PB this test

* removed tests

---------

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>
Co-authored-by: ssokolovich <ssokolovich@paloaltonetworks.com>
sapirshuker pushed a commit that referenced this pull request Dec 21, 2023
* generic polling task was removed and read me file created

* Release notes update

* release notes update

* old playbook deprecated and new version created

* release notes added

* added image to the old playbook version

* deprecated for the playbook

* RN updated

* added image

* removed unnecessary tasks

* added more outputs

* RN updated

* added description

* image replaced

* added an instance to a test PB

* removed tests instances
removed from PB this test

* removed tests

---------

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>
Co-authored-by: ssokolovich <ssokolovich@paloaltonetworks.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* generic polling task was removed and read me file created

* Release notes update

* release notes update

* old playbook deprecated and new version created

* release notes added

* added image to the old playbook version

* deprecated for the playbook

* RN updated

* added image

* removed unnecessary tasks

* added more outputs

* RN updated

* added description

* image replaced

* added an instance to a test PB

* removed tests instances
removed from PB this test

* removed tests

---------

Co-authored-by: Sasha Sokolovich <88268646+ssokolovich@users.noreply.github.com>
Co-authored-by: ssokolovich <ssokolovich@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants