changed test to correspond to the latest changes on xsoar8 #31531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing UT reproducing the issue https://github.com/demisto/content/actions/runs/7245804734/job/19736527185 |
|
you only changed a test file here? |
|
code.pan.run is failing on a known issue with cloud tenants' installation of packs, see this. |
sapirshuker
pushed a commit
that referenced
this pull request
Dec 21, 2023
* changed test to correspond to the latest changes on xsoar8 * Apply ruff * Changed loop to work without total * Changed loop to work without total * Bumped docker * fixed test * fixed test once more
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
* changed test to correspond to the latest changes on xsoar8 * Apply ruff * Changed loop to work without total * Changed loop to work without total * Bumped docker * fixed test * fixed test once more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-31482
Description
In XSOAR8
getIncidentsalways returnstotal:0(breaking changes), so we cannot use it in our loop. Instead, we check every loop if the page contains exactly 100 (page size) results, if so it means we might have a next page. We finish the loop when either we have pulled all results or when the number of results is smaller than 100.Must have