Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awssns listener #31633

Merged
merged 72 commits into from Feb 19, 2024
Merged

Awssns listener #31633

merged 72 commits into from Feb 19, 2024

Conversation

thefrieddan1
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Create a new long running integration that can confirm subscruption to AWS - SNS and create incidents from SNS msgs.

Must have

  • Tests
  • Documentation

@thefrieddan1 thefrieddan1 self-assigned this Dec 21, 2023
@thefrieddan1 thefrieddan1 requested review from michal-dagan and removed request for michal-dagan December 21, 2023 09:49
@thefrieddan1 thefrieddan1 marked this pull request as ready for review December 21, 2023 09:51
@thefrieddan1 thefrieddan1 requested review from ShirleyDenkberg and removed request for michal-dagan December 21, 2023 09:51
@ShirleyDenkberg ShirleyDenkberg self-assigned this Dec 21, 2023
Copy link

github-actions bot commented Feb 11, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AWS-SNS-Listener/Integrations/AWSSNSListener
   AWSSNSListener.py811482%65–66, 70–71, 78, 91–93, 100, 121–124, 131
Packs/Base/Scripts/CommonServerPython
   CommonServerPython.py432066784%167–170, 181, 183, 407, 449, 543, 568–572, 597, 612, 752–753, 762, 803–804, 822, 852–856, 860–862, 904, 991–999, 1043–1048, 1082–1084, 1214–1218, 1221–1222, 1224–1226, 1240–1242, 1244, 1310, 1323, 1336, 1344–1346, 1348, 1361, 1369, 1456–1457, 1512, 1534–1535, 1538, 1544, 1546, 1548, 1642, 1687, 1761–1764, 1802–1803, 1817–1822, 1824, 1892, 1975, 1977, 1997, 2027, 2031, 2073, 2252, 2276, 2315–2316, 2396–2397, 2399, 2412–2419, 2421, 2498–2500, 2514, 2527, 2558, 2564–2568, 2570–2572, 2574, 2578–2579, 2581, 2594–2600, 2604, 2608–2610, 2616–2617, 2629, 2657, 2660, 2665, 2685, 2691, 2693, 2695, 2715, 2718, 2730, 2776–2784, 2786, 2845, 2867, 2887, 2945, 2957–2958, 3070, 3072, 3247, 3257, 3263, 3272, 3278, 3292, 3348, 3363, 3365, 3396–3401, 3404, 3455–3456, 3459, 3625–3626, 3629, 3736, 3739, 3964, 3967, 3970, 3973, 3978, 3987, 4013, 4019, 4022, 4031, 4033, 4149–4150, 4174, 4176, 4195, 4198, 4201, 4269, 4290, 4292, 4428, 4446, 4458, 4494, 4496, 4670–4671, 4749, 4751, 4776, 4791–4807, 4810, 4814–4815, 4817–4818, 4820–4821, 4823–4824, 4826–4827, 4829–4830, 4832–4833, 4835–4836, 4838–4839, 4841–4842, 4844–4845, 4847–4848, 4850–4851, 4853, 4855–4856, 4858–4861, 4863–4865, 4867, 4869, 4873, 4944, 4976, 4982, 4984, 5022, 5027–5028, 5033, 5037–5038, 5040, 5122, 5128, 5220, 5241, 5244–5249, 5257–5263, 5265–5266, 5311, 5324, 5419–5422, 5427, 5430, 5433, 5467, 5470, 5514, 5516, 5518, 5613, 5664, 5746, 5758, 5776, 5816–5817, 5821, 5823, 5857, 5861, 5863, 5865, 5867, 5913, 5917, 6016–6019, 6021, 6034, 6053, 6063, 6069, 6078–6080, 6083–6086, 6101, 6143, 6172, 6175, 6224–6227, 6230–6234, 6238, 6246, 6252, 6280, 6309, 6315–6316, 6367, 6387–6388, 6390, 6430–6431, 6438, 6443, 6449, 6462–6463, 6465, 6736–6738, 6757, 6770, 6782, 6810, 6970, 6985, 7050, 7080, 7118–7119, 7131, 7146–7147, 7149–7150, 7152–7153, 7155–7156, 7158–7161, 7163, 7165–7166, 7168, 7247–7248, 7260, 7300–7303, 7305, 7312–7313, 7398, 7407, 7416, 7425, 7434, 7443, 7452, 7460, 7515, 7550, 7570, 7572, 7673, 7833–7836, 7838–7840, 7899, 7918–7919, 7931, 7947, 7968–7969, 7971, 7988, 8075, 8089, 8092–8095, 8098, 8101, 8123–8126, 8223, 8242–8243, 8371, 8421, 8425–8426, 8440, 8443, 8456–8458, 8461, 8533, 8703–8704, 8778, 8780–8782, 8826–8827, 8829, 8832, 8843, 8849–8852, 8854, 8856, 8858–8859, 8972, 9003, 9014, 9017, 9046–9051, 9148–9149, 9153, 9214–9217, 9219, 9241, 9253, 9349, 9385–9386, 9399, 9412–9417, 9433–9434, 9442–9443, 9456, 9464–9465, 9482–9483, 9497, 9507, 9523, 9534, 9542–9544, 9546, 9572, 9587, 9598, 9616–9617, 9620, 9638, 9641, 9656, 9670, 9676, 9691, 9708, 9720–9728, 9731–9732, 9734, 9749–9751, 9762, 9765, 9853, 9879, 9886, 9930, 9956–9957, 10000, 10002–10004, 10006, 10077, 10086, 10207, 10271, 10275–10276, 10367–10372, 10467–10470, 10560–10562, 10588, 10621, 10671–10672, 10677–10678, 10695, 10781–10783, 10802, 11010, 11126, 11150, 11173, 11198, 11205–11211, 11213, 11215, 11354, 11402–11403, 11405–11412, 11417–11419, 11421, 11423, 11520–11521, 11539, 11572–11573, 11577
TOTAL440168184% 

Tests Skipped Failures Errors Time
692 12 💤 0 ❌ 0 🔥 29.125s ⏱️

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@thefrieddan1 thefrieddan1 merged commit 3588960 into master Feb 19, 2024
16 checks passed
@thefrieddan1 thefrieddan1 deleted the awssns_listener branch February 19, 2024 06:08
maimorag pushed a commit that referenced this pull request Feb 22, 2024
* init commit

* Adding missing files,

* Remove unnecessary imports

* Adding test playbook.
Removing redundant fields from yml conf

* Adding the TPB to the yml test

* Ignoring secret
Deleting redundant file

* Fix validations issues

* Edit readme files.

* flake8 error

* Adding image

* Remove redundant import

* Remove redundant file.
Fix image name.

* Apply suggestions from code review

tech doc review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Fix wrong descriptions.

* Fix description in yml and README.
Fix TestPlaybook

* Add instance_names to TPB

* Adding store sample logic

* update docker version.

* Add a unique endpoint instead of the server builtin endpoint

* Adding validation to messages

* testing long running port

* with comments

* adding comments

* working

* Trying to validate the request

* Added proxy and verify to call

* Removed redundant log writes.
Added validation for version2

* Added integration username and password specific verification

* bump docker version

* Added additional info to username command

* updated the README

* Logs refactoring

* Specified a version in README

* remove TODO

* README description and yml changes.

* Code review changes

* Added support for baseclient
Added CSP implementation of handle proxy for long runnning integrations

* Code review changes

* Split long functions

* Extracting server config

* RN for CSP

* Fix READMS. bump docker version.

* ignoring false positive secrets

* changes ep on tbp

* ignore AWS-SNS_Listener TPB

* after merge from master

* Add unit tests

* ignore false positive secret

* fix pragma no cover annotation.
Bump Base version

* ignore demitso.error print from test.

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
* init commit

* Adding missing files,

* Remove unnecessary imports

* Adding test playbook.
Removing redundant fields from yml conf

* Adding the TPB to the yml test

* Ignoring secret
Deleting redundant file

* Fix validations issues

* Edit readme files.

* flake8 error

* Adding image

* Remove redundant import

* Remove redundant file.
Fix image name.

* Apply suggestions from code review

tech doc review

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Fix wrong descriptions.

* Fix description in yml and README.
Fix TestPlaybook

* Add instance_names to TPB

* Adding store sample logic

* update docker version.

* Add a unique endpoint instead of the server builtin endpoint

* Adding validation to messages

* testing long running port

* with comments

* adding comments

* working

* Trying to validate the request

* Added proxy and verify to call

* Removed redundant log writes.
Added validation for version2

* Added integration username and password specific verification

* bump docker version

* Added additional info to username command

* updated the README

* Logs refactoring

* Specified a version in README

* remove TODO

* README description and yml changes.

* Code review changes

* Added support for baseclient
Added CSP implementation of handle proxy for long runnning integrations

* Code review changes

* Split long functions

* Extracting server config

* RN for CSP

* Fix READMS. bump docker version.

* ignoring false positive secrets

* changes ep on tbp

* ignore AWS-SNS_Listener TPB

* after merge from master

* Add unit tests

* ignore false positive secret

* fix pragma no cover annotation.
Bump Base version

* ignore demitso.error print from test.

---------

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants