New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awssns listener #31633
Merged
Merged
Awssns listener #31633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing redundant fields from yml conf
Deleting redundant file
Fix image name.
tech doc review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Fix TestPlaybook
thefrieddan1
requested review from
michal-dagan
and removed request for
michal-dagan
December 21, 2023 09:49
thefrieddan1
requested review from
ShirleyDenkberg
and removed request for
michal-dagan
December 21, 2023 09:51
DeanArbel
reviewed
Feb 11, 2024
Packs/AWS-SNS-Listener/Integrations/AWSSNSListener/AWSSNSListener.py
Outdated
Show resolved
Hide resolved
Packs/AWS-SNS-Listener/Integrations/AWSSNSListener/AWSSNSListener.py
Outdated
Show resolved
Hide resolved
DeanArbel
reviewed
Feb 11, 2024
DeanArbel
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
Packs/AWS-SNS-Listener/Integrations/AWSSNSListener/AWSSNSListener.py
Outdated
Show resolved
Hide resolved
Packs/AWS-SNS-Listener/Integrations/AWSSNSListener/AWSSNSListener.py
Outdated
Show resolved
Hide resolved
Bump Base version
maimorag
pushed a commit
that referenced
this pull request
Feb 22, 2024
* init commit * Adding missing files, * Remove unnecessary imports * Adding test playbook. Removing redundant fields from yml conf * Adding the TPB to the yml test * Ignoring secret Deleting redundant file * Fix validations issues * Edit readme files. * flake8 error * Adding image * Remove redundant import * Remove redundant file. Fix image name. * Apply suggestions from code review tech doc review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Fix wrong descriptions. * Fix description in yml and README. Fix TestPlaybook * Add instance_names to TPB * Adding store sample logic * update docker version. * Add a unique endpoint instead of the server builtin endpoint * Adding validation to messages * testing long running port * with comments * adding comments * working * Trying to validate the request * Added proxy and verify to call * Removed redundant log writes. Added validation for version2 * Added integration username and password specific verification * bump docker version * Added additional info to username command * updated the README * Logs refactoring * Specified a version in README * remove TODO * README description and yml changes. * Code review changes * Added support for baseclient Added CSP implementation of handle proxy for long runnning integrations * Code review changes * Split long functions * Extracting server config * RN for CSP * Fix READMS. bump docker version. * ignoring false positive secrets * changes ep on tbp * ignore AWS-SNS_Listener TPB * after merge from master * Add unit tests * ignore false positive secret * fix pragma no cover annotation. Bump Base version * ignore demitso.error print from test. --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Feb 28, 2024
* init commit * Adding missing files, * Remove unnecessary imports * Adding test playbook. Removing redundant fields from yml conf * Adding the TPB to the yml test * Ignoring secret Deleting redundant file * Fix validations issues * Edit readme files. * flake8 error * Adding image * Remove redundant import * Remove redundant file. Fix image name. * Apply suggestions from code review tech doc review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Fix wrong descriptions. * Fix description in yml and README. Fix TestPlaybook * Add instance_names to TPB * Adding store sample logic * update docker version. * Add a unique endpoint instead of the server builtin endpoint * Adding validation to messages * testing long running port * with comments * adding comments * working * Trying to validate the request * Added proxy and verify to call * Removed redundant log writes. Added validation for version2 * Added integration username and password specific verification * bump docker version * Added additional info to username command * updated the README * Logs refactoring * Specified a version in README * remove TODO * README description and yml changes. * Code review changes * Added support for baseclient Added CSP implementation of handle proxy for long runnning integrations * Code review changes * Split long functions * Extracting server config * RN for CSP * Fix READMS. bump docker version. * ignoring false positive secrets * changes ep on tbp * ignore AWS-SNS_Listener TPB * after merge from master * Add unit tests * ignore false positive secret * fix pragma no cover annotation. Bump Base version * ignore demitso.error print from test. --------- Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Create a new long running integration that can confirm subscruption to AWS - SNS and create incidents from SNS msgs.
Must have