Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taxii 2 feed last run issue fix #31733

Merged
merged 46 commits into from Jan 7, 2024
Merged

Taxii 2 feed last run issue fix #31733

merged 46 commits into from Jan 7, 2024

Conversation

YuvHayun
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-9230

Description

Taxii 2 feed last run issue fix

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2023 •
edited

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/TAXIIServer/Integrations/TAXII2Server
   TAXII2Server.py7079286%142, 172, 179, 200, 225, 302, 342, 426–427, 509–510, 645, 648–650, 653, 656, 661–662, 664, 681, 703–704, 706–707, 738, 771, 773, 776, 800–801, 807–808, 818, 889, 970–971, 973–976, 978, 991–992, 1005–1006, 1022, 1033, 1056–1059, 1080–1083, 1120–1123, 1145–1148, 1185–1188, 1234–1237, 1258–1259, 1341–1342, 1344, 1348–1350, 1393–1394, 1397, 1418, 1424–1426, 1434, 1439–1440, 1442, 1444
TOTAL7079286% 

Tests Skipped Failures Errors Time
50 0 💤 0 ❌ 0 🔥 2.930s ⏱️

@YuvHayun YuvHayun force-pushed the taxii_2_feed_last_run_issue_fix branch from 632af6e to 7c2826e Compare January 3, 2024 16:02
@YuvHayun
Copy link
Contributor Author

YuvHayun commented Jan 7, 2024

Need force merge on this pr, failing due to known issue with taxii performance test on Xsoar NG.

@dantavori dantavori merged commit b7cbbac into master Jan 7, 2024
19 of 20 checks passed
@dantavori dantavori deleted the taxii_2_feed_last_run_issue_fix branch January 7, 2024 10:38
maimorag pushed a commit that referenced this pull request Jan 7, 2024
@YuvHayun @maimorag
Taxii 2 feed last run issue fix (#31733)
f6d2b8e 
* implement logs

* moved more validations to new format.

* test

* save

* fixes

* fixes

* pre commit fixes

* reverts

* pre commit fixes

* reverts and fixes

* reverts and fixes

* added rn

* pre commit fixes

* test fix

* fixes

* reverts and fixes

* pre commit fixes

* reverts

* update docker

* reverts

* update docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JudahSchwartz JudahSchwartz JudahSchwartz approved these changes

@Ni-Knight Ni-Knight Awaiting requested review from Ni-Knight Ni-Knight is a code owner

@amshamah419 amshamah419 Awaiting requested review from amshamah419

@thefrieddan1 thefrieddan1 Awaiting requested review from thefrieddan1

Assignees
No one assigned
Labels
docs-approved ForceMerge
Projects
None yet
Milestone
No milestone
3 participants
@YuvHayun @JudahSchwartz @dantavori