Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add types-protobuf, fix AWSWAF type hint #31792

Merged
merged 6 commits into from Dec 27, 2023
Merged

add types-protobuf, fix AWSWAF type hint #31792

merged 6 commits into from Dec 27, 2023

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Dec 26, 2023 •
edited

  • Added the types-protobuf dependency
  • Fixed an AWSWAF type hint

related: https://jira-dc.paloaltonetworks.com/browse/CIAC-9177

following this comment

test nightly

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 27, 2023 •
edited

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/AWS_WAF/Integrations/AWSWAF
   AWSWAF.py3108672%11–12, 184, 258, 280, 296, 381–382, 387, 396, 398, 445, 447–450, 452, 498, 500, 556, 574, 623, 625, 681, 699, 744, 820, 822, 838, 840, 842–843, 845, 851, 853, 859, 861, 863–864, 866, 872, 874, 880, 882, 884–885, 887, 893, 895, 901, 903–905, 907, 913, 915, 921–925, 927, 933, 935, 941, 943–946, 948, 954, 957, 963, 965, 967–968, 970, 976, 979, 985, 987, 989–990, 992, 998, 1000
TOTAL3108672% 

Tests Skipped Failures Errors Time
33 0 💤 0 ❌ 0 🔥 2.212s ⏱️

@dorschw dorschw marked this pull request as ready for review December 27, 2023 14:27
@dorschw dorschw changed the title add types-protobuf add types-protobuf, fix AWSWAF type hint Dec 27, 2023
@dorschw dorschw merged commit 1b63483 into master Dec 27, 2023
22 of 23 checks passed
@dorschw dorschw deleted the ds-types-protobuf branch December 27, 2023 14:27
maimorag pushed a commit that referenced this pull request Dec 28, 2023
@dorschw @maimorag
add types-protobuf, fix AWSWAF type hint (#31792)
7c02685 
* add types-protobuf

* fix invalid type

* pre-commit

* rn

* bump, RN
maimorag pushed a commit that referenced this pull request Dec 31, 2023
@dorschw @maimorag
add types-protobuf, fix AWSWAF type hint (#31792)
20627e5 
* add types-protobuf

* fix invalid type

* pre-commit

* rn

* bump, RN
maimorag pushed a commit that referenced this pull request Dec 31, 2023
@dorschw @maimorag
add types-protobuf, fix AWSWAF type hint (#31792)
db46cb2 
* add types-protobuf

* fix invalid type

* pre-commit

* rn

* bump, RN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilaner ilaner ilaner approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
2 participants
@dorschw @ilaner