ANYRUN Add Command line parameter #31802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add command line parameter obj_ext_cmd
Add command line parameter
Add command line parameter
|
|
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/vasilydavydov_vasilydavydov-patch-1
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @adi88d will know the proposed changes are ready to be reviewed. |
|
Hi @vasilydavydov, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link. |
content-bot
added
Community
Contribution Form Filled
|
@vasilydavydov |
adi88d
requested changes
Dec 27, 2023
There was a problem hiding this comment.
Hi @vasilydavydov ,
Thank you for your contribution!
Good work :)
- Please bump the pack version in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run thedemisto-sdk update-release-notescommand - for more information please see: https://xsoar.pan.dev/docs/concepts/demisto-sdk#update-release-notes. - Please attach screenshot or pdf file for this request API documentation
| @@ -865,7 +865,7 @@ def run_analysis(args): | |||
| files = { | |||
| 'file': (name, open(file_path, 'rb')) | |||
| } | |||
|
|
|||
Comment on lines
881
to
882
| if obj_type == 'file' or obj_type == 'download' : | ||
| args['obj_ext_cmd'] = args.get('obj_ext_cmd') |
There was a problem hiding this comment.
Suggested change
| if obj_type == 'file' or obj_type == 'download' : | |
| args['obj_ext_cmd'] = args.get('obj_ext_cmd') | |
| if obj_ext_cmd and (obj_type == 'file' or obj_type == 'download'): | |
| args['obj_ext_cmd'] = args.get('obj_ext_cmd') |
and add this :
obj_ext_cmd = args.get('obj_ext_cmd')
in line 854 under:
obj_type = args.get('obj_type')
adi88d
added
the
pending-contributor
Change minor version
Add command line parameter description to release noter
Update description command line paremeter
|
Hello,
Pack_metadata.json and the new Release Notes file were updated in current brunch
Screenshot of documentation is here (link<https://any.run/api-documentation/#api-Analysis-PostAnalysis>)
***@***.***
Best regards,
Vasily Davydov | Product Manager | ANY.RUN
Mobile: +995 555 136 849<tel:+995555136849> | ***@***.******@***.***>
From: Adi Daud ***@***.***>
Date: Wednesday, 27 December 2023 at 14:53
To: demisto/content ***@***.***>
Cc: Vasily Davydov ***@***.***>, Mention ***@***.***>
Subject: Re: [demisto/content] ANYRUN Add Command line parameter (PR #31802)
@adi88d requested changes on this pull request.
Hi @vasilydavydov<https://github.com/vasilydavydov> ,
Thank you for your contribution!
Good work :)
* Please bump the pack version in the pack_metadata.json file and add notes describing your changes to a new Release Notes file.
To do that, please run the demisto-sdk update-release-notes command - for more information please see: https://xsoar.pan.dev/docs/concepts/demisto-sdk#update-release-notes.
* Please attach screenshot or pdf file for this request API documentation
________________________________
In Packs/ANYRUN/Integrations/ANYRUN/ANYRUN.py<#31802 (comment)>:
@@ -865,7 +865,7 @@ def run_analysis(args):
files = {
'file': (name, open(file_path, 'rb'))
}
-
+
revert this
________________________________
In Packs/ANYRUN/Integrations/ANYRUN/ANYRUN.py<#31802 (comment)>:
+ if obj_type == 'file' or obj_type == 'download' :
+ args['obj_ext_cmd'] = args.get('obj_ext_cmd')
⬇️ Suggested change
- if obj_type == 'file' or obj_type == 'download' :
- args['obj_ext_cmd'] = args.get('obj_ext_cmd')
+ if obj_ext_cmd and (obj_type == 'file' or obj_type == 'download'):
+ args['obj_ext_cmd'] = args.get('obj_ext_cmd')
and add this :
obj_ext_cmd = args.get('obj_ext_cmd')
in line 854 under:
obj_type = args.get('obj_type')
—
Reply to this email directly, view it on GitHub<#31802 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BE5UTTL3Y2O26RU2SNXCIR3YLP42FAVCNFSM6AAAAABBEFF3NWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJXGA2DGOJSHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@adi88d Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
adi88d
approved these changes
Dec 28, 2023
adi88d
merged commit ecc2c91
into
demisto:contrib/vasilydavydov_vasilydavydov-patch-1
11 of 14 checks passed
5 tasks
adi88d
added a commit
that referenced
this pull request
Dec 28, 2023
* ANYRUN Add Command line parameter (#31802) * update docker --------- Co-authored-by: vasilydavydov <154880461+vasilydavydov@users.noreply.github.com> Co-authored-by: adi88d <adaud@paloaltonetworks.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Dec 28, 2023
* ANYRUN Add Command line parameter (#31802) * update docker --------- Co-authored-by: vasilydavydov <154880461+vasilydavydov@users.noreply.github.com> Co-authored-by: adi88d <adaud@paloaltonetworks.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
* ANYRUN Add Command line parameter (#31802) * update docker --------- Co-authored-by: vasilydavydov <154880461+vasilydavydov@users.noreply.github.com> Co-authored-by: adi88d <adaud@paloaltonetworks.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
maimorag
pushed a commit
that referenced
this pull request
Dec 31, 2023
* ANYRUN Add Command line parameter (#31802) * update docker --------- Co-authored-by: vasilydavydov <154880461+vasilydavydov@users.noreply.github.com> Co-authored-by: adi88d <adaud@paloaltonetworks.com> Co-authored-by: Adi Daud <46249224+adi88d@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have