Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageOCR] move to parameter #31810

Merged
merged 4 commits into from Dec 27, 2023
Merged

[ImageOCR] move to parameter #31810

merged 4 commits into from Dec 27, 2023

Conversation

dantavori
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-31355

Description

Removed the skip_corrupted argument from the image-ocr-list-languages command to be an integration parameter instead.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Dec 27, 2023

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ImageOCR/Integrations/ImageOCR
   ImageOCR.py76790%13, 16, 48, 81–82, 109, 116
TOTAL76790% 

Tests Skipped Failures Errors Time
13 0 💤 0 ❌ 0 🔥 8m 25s ⏱️

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
@dantavori dantavori merged commit b38ccd0 into master Dec 27, 2023
14 of 17 checks passed
@dantavori dantavori deleted the image-ocr-bc branch December 27, 2023 18:46
maimorag pushed a commit that referenced this pull request Dec 28, 2023
* move to parameter

* fix param issue

* Update Packs/ImageOCR/Integrations/ImageOCR/README.md

* Update Packs/ImageOCR/ReleaseNotes/1_1_24.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* move to parameter

* fix param issue

* Update Packs/ImageOCR/Integrations/ImageOCR/README.md

* Update Packs/ImageOCR/ReleaseNotes/1_1_24.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Dec 31, 2023
* move to parameter

* fix param issue

* Update Packs/ImageOCR/Integrations/ImageOCR/README.md

* Update Packs/ImageOCR/ReleaseNotes/1_1_24.md

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>

---------

Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants