Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self references in CommonServerPowershell #31816

Merged
merged 23 commits into from Jan 10, 2024
Merged

Remove self references in CommonServerPowershell #31816

merged 23 commits into from Jan 10, 2024

Conversation

DinaMeylakh
Copy link
Contributor

@DinaMeylakh DinaMeylakh commented Dec 27, 2023 •
edited

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Remove self referencing properties from raw results. They are recursively converted to json causing duplication in results.

Must have

  • Tests
  • Documentation

@DinaMeylakh DinaMeylakh added the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Dec 27, 2023
@DinaMeylakh DinaMeylakh marked this pull request as ready for review December 27, 2023 18:02
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.33.11.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@DinaMeylakh DinaMeylakh changed the title Remove self references in CommonServerPowershell raw results Remove self references in CommonServerPowershell Jan 4, 2024
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.33.15.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.33.16.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Base pack version was bumped to 1.33.17.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

ShahafBenYakir
ShahafBenYakir approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Packs/Base/Scripts/CommonServerPowerShell/CommonServerPowerShell.ps1 Show resolved Hide resolved
Packs/Base/Scripts/CommonServerPowerShell/CommonServerPowerShell.ps1 Show resolved Hide resolved
@DinaMeylakh DinaMeylakh merged commit 060c2db into master Jan 10, 2024
20 checks passed
@DinaMeylakh DinaMeylakh deleted the remove_self_references_powershell branch January 10, 2024 15:23
dantavori pushed a commit that referenced this pull request Jan 14, 2024
@DinaMeylakh @dantavori
Remove self references in CommonServerPowershell (#31816)
aa4c62d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShahafBenYakir ShahafBenYakir ShahafBenYakir approved these changes

Assignees
No one assigned
Labels
docs-approved release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process
Projects
None yet
Milestone
No milestone
3 participants
@DinaMeylakh @content-bot @ShahafBenYakir