Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASM] - EXPANDR-6923 Prisma cloud changes #31855

Merged
merged 4 commits into from Jan 7, 2024
Merged

[ASM] - EXPANDR-6923 Prisma cloud changes #31855

merged 4 commits into from Jan 7, 2024

Conversation

capanw
Copy link
Contributor

@capanw capanw commented Dec 29, 2023 •
edited

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6923

Description

Prisma cloud event search changes and fixing Azure enrichment bug.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Dec 29, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_6923 December 29, 2023 19:52
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @capanw, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@capanw capanw marked this pull request as draft December 29, 2023 21:44
@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Jan 1, 2024
@melamedbn melamedbn removed their request for review January 2, 2024 12:18
@melamedbn melamedbn removed their assignment Jan 2, 2024
@johnnywilkes
Copy link
Contributor

@capanw , if you can add the ticket to the related issue section, please https://jira-dc.paloaltonetworks.com/browse/EXPANDR-6923

johnnywilkes
johnnywilkes approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , i approve

@capanw capanw marked this pull request as ready for review January 2, 2024 19:07
@capanw
Copy link
Contributor Author

capanw commented Jan 2, 2024

@YuvHayun, approved from our side. Please proceed to review and merge.

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 4, 2024
@content-bot
Copy link
Collaborator

content-bot commented Jan 4, 2024 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/745244

@YuvHayun
Copy link
Contributor

YuvHayun commented Jan 4, 2024

hey @capanw @johnnywilkes, please pull from master and push changes.

@capanw
Copy link
Contributor Author

capanw commented Jan 4, 2024

Hello @YuvHayun, did a rebase with latest changes from master.

@YuvHayun YuvHayun added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jan 4, 2024
@YuvHayun
Copy link
Contributor

YuvHayun commented Jan 7, 2024

Merging to internal pr.

@YuvHayun YuvHayun merged commit 310777b into demisto:contrib/PaloAltoNetworks_6923 Jan 7, 2024
23 of 29 checks passed
@content-bot content-bot mentioned this pull request Jan 7, 2024
Merged
5 tasks
YuvHayun added a commit that referenced this pull request Jan 7, 2024
@content-bot @capanw @YuvHayun
[ASM] - EXPANDR-6923 Prisma cloud changes (#31855) (#31995)
1bae39d 
* Prisma cloud changes

* Update pack_metadata.json version

* Rename 1_7_17.md to 1_7_18.md

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
maimorag pushed a commit that referenced this pull request Jan 7, 2024
@content-bot @capanw
@YuvHayun @maimorag
[ASM] - EXPANDR-6923 Prisma cloud changes (#31855) (#31995)
7bba668 
* Prisma cloud changes

* Update pack_metadata.json version

* Rename 1_7_17.md to 1_7_18.md

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnywilkes johnnywilkes johnnywilkes approved these changes

@BigEasyJ BigEasyJ BigEasyJ approved these changes

@YuvHayun YuvHayun YuvHayun approved these changes

Assignees

@YuvHayun YuvHayun

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
6 participants
@capanw @content-bot @johnnywilkes @YuvHayun @BigEasyJ @melamedbn