Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - Expander - Organizational scope searching for EC2 #31856

Conversation

johnnywilkes
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://jira-dc.paloaltonetworks.com/browse/EXPANDR-5778

Description

The recommended way to search for an EC2 instance by public IP is called IPAM Public IP Insights (https://aws.amazon.com/about-aws/whats-new/2023/07/aws-public-ip-insights-vpc-ip-address-manager/) and it just got API to access data (commands added in #31165). This PR increases the abilities of the AWS - Enrichment playbook to use the AWS IPAM Public IP Insights API to search for an IP address on of an EC2 instance in the organization scope and to pull additional information on it.

This PR specifically adds the AWSAssumeRoleName optional input in the case of assuming roles for AWS.

Must have

  • Tests
  • Documentation

@johnnywilkes johnnywilkes marked this pull request as draft December 29, 2023 20:45
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Dec 29, 2023
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_ASM-EXPANDR-5778 December 29, 2023 20:46
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yucohen will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @johnnywilkes, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@johnnywilkes
Copy link
Contributor Author

@ShirleyDenkberg , please review when possible

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Dec 29, 2023
@johnnywilkes
Copy link
Contributor Author

@capanw , if you have time, please review, blocked by #31849

@yucohen yucohen added the pending-contributor The PR is pending the response of its creator label Jan 1, 2024
@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 2, 2024
@ShirleyDenkberg
Copy link
Contributor

@melamedbn @yucohen Doc review completed.

@melamedbn melamedbn removed their request for review January 2, 2024 12:16
@melamedbn melamedbn removed their assignment Jan 2, 2024
@johnnywilkes
Copy link
Contributor Author

@capanw / @BigEasyJ , please look over, still blocked by #31958

Copy link
Contributor

@capanw capanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BigEasyJ BigEasyJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@johnnywilkes johnnywilkes marked this pull request as ready for review January 10, 2024 12:23
@johnnywilkes
Copy link
Contributor Author

@yucohen , this has been approved by Xpanse, please merge when possible

@yucohen
Copy link
Contributor

yucohen commented Jan 11, 2024

@johnnywilkes @BigEasyJ On it :)

@yucohen yucohen merged commit c5e4b9e into demisto:contrib/PaloAltoNetworks_ASM-EXPANDR-5778 Jan 11, 2024
20 of 21 checks passed
yucohen pushed a commit that referenced this pull request Jan 11, 2024
…32135)

* playbook changes

* RN and READMEs

* RN take2

* Update pack_metadata.json version to latest

* Rename 1_7_17.md to 1_7_18.md

* bumpty bump

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
dantavori pushed a commit that referenced this pull request Jan 14, 2024
…32135)

* playbook changes

* RN and READMEs

* RN take2

* Update pack_metadata.json version to latest

* Rename 1_7_17.md to 1_7_18.md

* bumpty bump

---------

Co-authored-by: johnnywilkes <32227961+johnnywilkes@users.noreply.github.com>
Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-contributor The PR is pending the response of its creator Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
7 participants