New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forcepoint dlp eventcollector #31892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech doc review Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…DLP_1_4_schema.json
5 tasks
tkatzir
approved these changes
Jan 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some important comments.
Approved, so you won't be blocked once you address the important comments.
Also, @ShirleyDenkberg should review the customer facing English.
In these files:
- ForcepointEventCollector.yml
- ForcepointEventCollector_description.md
- README.md
- ReleaseNotes/1_0_2.md
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
kobymeir
commented
Jan 2, 2024
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
kobymeir
commented
Jan 2, 2024
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
kobymeir
commented
Jan 2, 2024
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
kobymeir
commented
Jan 2, 2024
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.py
Outdated
Show resolved
Hide resolved
Co-authored-by: tkatzir <tkatzir@paloaltonetworks.com>
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector.yml
Outdated
Show resolved
Hide resolved
.../ForcepointDLP/Integrations/ForcepointEventCollector/ForcepointEventCollector_description.md
Show resolved
Hide resolved
Packs/ForcepointDLP/Integrations/ForcepointEventCollector/README.md
Outdated
Show resolved
Hide resolved
@tkatzir Doc review completed. |
kobymeir
commented
Jan 2, 2024
kobymeir
commented
Jan 2, 2024
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
kobymeir
commented
Jan 2, 2024
maimorag
pushed a commit
that referenced
this pull request
Jan 7, 2024
Forcepoint dlp eventcollector #31892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-6820
Description
Forcepoint DLP Event Collector
Must have