Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xdr change command results list #31956

Merged
merged 28 commits into from Jan 10, 2024
Merged

Xdr change command results list #31956

merged 28 commits into from Jan 10, 2024

Conversation

daryakoval
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-9380

Description

Changed command results list to a single command result.

Must have

  • Tests
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024 •
edited

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/CoreIRApiModule
   CoreIRApiModule.py151423584%195, 200, 243, 258, 269, 281, 341–342, 348–353, 378, 384, 390, 402, 412, 418, 437, 449, 455, 461, 473, 483, 489, 525, 560, 589, 605, 607, 715, 745, 748, 758, 828, 834, 854, 860, 862, 889, 905, 1091, 1115, 1121, 1134, 1136–1137, 1139, 1145–1146, 1152–1153, 1159, 1166–1167, 1200, 1202, 1248, 1255, 1262, 1268, 1274, 1281, 1288, 1298, 1328, 1404–1407, 1409–1415, 1420, 1425–1428, 1430–1431, 1433–1434, 1436–1440, 1442–1443, 1445, 1449, 1456–1457, 1472–1473, 1489, 1494, 1502, 1550–1552, 1556, 1559, 1583, 1668, 1674, 1678, 1682, 1687, 1693, 1705–1706, 1712, 1717, 1723, 1726–1728, 1760, 1763–1766, 1880, 1953, 1959, 1963, 1967, 1970, 2384, 2395, 2398–2400, 2404–2407, 2411–2412, 2418, 2420–2424, 2428, 2434, 2436–2437, 2439, 2443–2446, 2448, 2455, 2457–2458, 2461–2465, 2468, 2470, 2472, 2474–2477, 2481–2482, 2484–2489, 2491, 2522, 2697–2700, 2704–2705, 2716, 2780, 2809, 2811, 2813, 3054–3055, 3147–3149, 3157, 3178, 3292–3295, 3381, 3389, 3393–3394, 3452–3454, 3460, 3499, 3513, 3520, 3527, 3569, 3576, 3583, 3590, 3597, 3803, 3839–3842, 3844–3846, 3948
TOTAL151423584% 

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 2.808s ⏱️

@daryakoval daryakoval marked this pull request as ready for review January 8, 2024 12:31
@dansterenson dansterenson requested review from maimorag and removed request for dansterenson January 8, 2024 12:53
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CortexXDR pack version was bumped to 6.1.3.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • ctf01 pack version was bumped to 1.0.5.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

dantavori
dantavori approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, see some doc notes

Packs/ApiModules/Scripts/CoreIRApiModule/CoreIRApiModule.py Outdated Show resolved Hide resolved
Packs/Core/ReleaseNotes/3_0_6.md Outdated Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/6_1_3.md Outdated Show resolved Hide resolved
Packs/ctf01/ReleaseNotes/1_0_5.md Show resolved Hide resolved
Packs/CortexXDR/ReleaseNotes/6_1_3.md Show resolved Hide resolved
@daryakoval @dantavori
Apply suggestions from code review
b06a71a 
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
daryakoval and others added 3 commits January 10, 2024 10:56
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.0.7.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Core pack version was bumped to 3.0.8.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@daryakoval daryakoval merged commit 7181d66 into master Jan 10, 2024
16 of 17 checks passed
@daryakoval daryakoval deleted the xdr-change-command-results-list branch January 10, 2024 16:33
dantavori added a commit that referenced this pull request Jan 14, 2024
@daryakoval @dantavori
Xdr change command results list (#31956)
0478c7d 
* save change to command results

* precommit fixes

* revert get_script_execution_results_command

* fix tests

* rn

* fix bug found by the test playbbok

* Bump pack from version CortexXDR to 6.1.3.

* Bump pack from version ctf01 to 1.0.5.

* Apply suggestions from code review

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Bump pack from version Core to 3.0.7.

* save changes from cr in rn

* rn

* Bump pack from version Core to 3.0.8.

---------

Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantavori dantavori dantavori approved these changes

@maimorag maimorag Awaiting requested review from maimorag

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@daryakoval @content-bot @dantavori