[XSUP 31458] Fix test-module in PANW Enterprise DLP #31983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
||||||||||||||||||||||||||||||
YuvHayun
approved these changes
Jan 4, 2024
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
dantavori
reviewed
Jan 10, 2024
...rise_DLP/Integrations/Palo_Alto_Networks_Enterprise_DLP/Palo_Alto_Networks_Enterprise_DLP.py
Outdated
Show resolved
Hide resolved
| @@ -29,7 +29,6 @@ configuration: | |||
| - EU | |||
| - AP | |||
| - UK | |||
| defaultvalue: US,EU,AP,UK | |||
There was a problem hiding this comment.
what if a customer didn't configure this param because the default value fitted for him, and upgrades to your version?
There was a problem hiding this comment.
In my case it took the supported region in my DLP env (US), so I guess it will return the result for the support regions for the customers as well.
…_Networks_Enterprise_DLP/Palo_Alto_Networks_Enterprise_DLP.py Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
dantavori
approved these changes
Jan 10, 2024
dantavori
added a commit
that referenced
this pull request
Jan 14, 2024
* fix test-module * rn * rn * fix * fixed reset-last-run & increased coverage * Bump pack from version Palo_Alto_Networks_Enterprise_DLP to 2.0.9. * bump docker * Update Packs/Palo_Alto_Networks_Enterprise_DLP/Integrations/Palo_Alto_Networks_Enterprise_DLP/Palo_Alto_Networks_Enterprise_DLP.py Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> * Update Packs/Palo_Alto_Networks_Enterprise_DLP/ReleaseNotes/2_0_9.md Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com> --------- Co-authored-by: Content Bot <bot@demisto.com> Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
Fixed the test-module command where authenticating with credentials and the default report ID doesn't exist.