New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] PAN-OS by Palo Alto Networks - Content Pack Update #31985
[Marketplace Contribution] PAN-OS by Palo Alto Networks - Content Pack Update #31985
Conversation
Thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link |
The old PR link for reference: |
Hi @MLainer1 do you have any other suggestions for changes before we merge? |
Hi @amkoppad, can you attach a short video of the changes that you made in the integration? so we can see that it works as expected. |
Hi @MLainer1 I have fixed some errors. The ones that are remaining are inconsistency with release notes (docker image on yml and release notes is different). I am not sure how to fix them. If you can guide me that would be great. Also I am co-ordinating with the customer to arrange for a video demo. |
@amkoppad Are you going you update this PR? |
video1490852414.mp4Here is the demo on customer environment of the changes working as expected. |
@MLainer1 I have added the video demo. I am having some errors with the release notes. If you can help me rectify them that would be great help. Thank you |
@MLainer1 I added the changes to the release notes. |
@GuyAfik @jlevypaloalto @MLainer1 Doc review completed. |
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/835404 |
…mkoppad-contrib-PAN-OS-1
…mkoppad-contrib-PAN-OS-1
…mkoppad-contrib-PAN-OS-1
@MLainer1 Is there anything else from my end you need me to do? |
cc1cffc
into
demisto:contrib/xsoar-contrib_amkoppad-contrib-PAN-OS-1
Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days. |
…k Update (#31985) (#33088) * "contribution update to pack "PAN-OS by Palo Alto Networks"" * Update Panorama.yml * Update Panorama.py * Update Panorama.yml * Update Panorama_test.py * Update Panorama.yml * Update Panorama.py * pre-commit * Update 2_1_21.md * Update 2_1_21.md * Apply suggestions from code review * rn * rn --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com> Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…k Update (#31985) (#33088) * "contribution update to pack "PAN-OS by Palo Alto Networks"" * Update Panorama.yml * Update Panorama.py * Update Panorama.yml * Update Panorama_test.py * Update Panorama.yml * Update Panorama.py * pre-commit * Update 2_1_21.md * Update 2_1_21.md * Apply suggestions from code review * rn * rn --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com> Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…k Update (demisto#31985) (demisto#33088) * "contribution update to pack "PAN-OS by Palo Alto Networks"" * Update Panorama.yml * Update Panorama.py * Update Panorama.yml * Update Panorama_test.py * Update Panorama.yml * Update Panorama.py * pre-commit * Update 2_1_21.md * Update 2_1_21.md * Apply suggestions from code review * rn * rn --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com> Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
…k Update (#31985) (#33088) * "contribution update to pack "PAN-OS by Palo Alto Networks"" * Update Panorama.yml * Update Panorama.py * Update Panorama.yml * Update Panorama_test.py * Update Panorama.yml * Update Panorama.py * pre-commit * Update 2_1_21.md * Update 2_1_21.md * Apply suggestions from code review * rn * rn --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com> Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com> Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Status
Contributor
@amkoppad
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.