Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] PAN-OS by Palo Alto Networks - Content Pack Update #31985

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@amkoppad

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 4, 2024
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_amkoppad-contrib-PAN-OS-1 January 4, 2024 17:34
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @yucohen will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

@amkoppad
Copy link
Contributor

amkoppad commented Jan 4, 2024

The old PR link for reference:
#31239

@yucohen yucohen requested review from MLainer1 and removed request for yucohen January 7, 2024 09:19
@yucohen yucohen assigned MLainer1 and unassigned yucohen Jan 7, 2024
@amkoppad
Copy link
Contributor

Hi @MLainer1 do you have any other suggestions for changes before we merge?

@MLainer1
Copy link
Contributor

Hi @amkoppad, can you attach a short video of the changes that you made in the integration? so we can see that it works as expected.
Also make sure to fix the pre-commit and unit tests errors.

@MLainer1 MLainer1 added the pending-contributor The PR is pending the response of its creator label Jan 18, 2024
@amkoppad
Copy link
Contributor

amkoppad commented Jan 18, 2024

Hi @MLainer1 I have fixed some errors. The ones that are remaining are inconsistency with release notes (docker image on yml and release notes is different). I am not sure how to fix them. If you can guide me that would be great. Also I am co-ordinating with the customer to arrange for a video demo.

@MLainer1
Copy link
Contributor

MLainer1 commented Feb 5, 2024

@amkoppad Are you going you update this PR?

@amkoppad
Copy link
Contributor

amkoppad commented Feb 6, 2024

video1490852414.mp4

Here is the demo on customer environment of the changes working as expected.

@amkoppad
Copy link
Contributor

amkoppad commented Feb 6, 2024

@MLainer1 I have added the video demo. I am having some errors with the release notes. If you can help me rectify them that would be great help. Thank you

@amkoppad
Copy link
Contributor

@MLainer1 I added the changes to the release notes.

@ShirleyDenkberg
Copy link
Contributor

@GuyAfik @jlevypaloalto @MLainer1 Doc review completed.

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@MLainer1 MLainer1 added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Feb 18, 2024
@content-bot
Copy link
Collaborator

content-bot commented Feb 18, 2024

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/835404

@MLainer1 MLainer1 added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Feb 18, 2024
@MLainer1 MLainer1 added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Feb 18, 2024
@amkoppad
Copy link
Contributor

@MLainer1 Is there anything else from my end you need me to do?

@MLainer1 MLainer1 merged commit cc1cffc into demisto:contrib/xsoar-contrib_amkoppad-contrib-PAN-OS-1 Feb 25, 2024
19 of 21 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

MLainer1 added a commit that referenced this pull request Feb 25, 2024
…k Update (#31985) (#33088)

* "contribution update to pack "PAN-OS by Palo Alto Networks""

* Update Panorama.yml

* Update Panorama.py

* Update Panorama.yml

* Update Panorama_test.py

* Update Panorama.yml

* Update Panorama.py

* pre-commit

* Update 2_1_21.md

* Update 2_1_21.md

* Apply suggestions from code review



* rn

* rn

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com>
Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 26, 2024
…k Update (#31985) (#33088)

* "contribution update to pack "PAN-OS by Palo Alto Networks""

* Update Panorama.yml

* Update Panorama.py

* Update Panorama.yml

* Update Panorama_test.py

* Update Panorama.yml

* Update Panorama.py

* pre-commit

* Update 2_1_21.md

* Update 2_1_21.md

* Apply suggestions from code review



* rn

* rn

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com>
Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
rundssoar pushed a commit to rundssoar/content that referenced this pull request Feb 28, 2024
…k Update (demisto#31985) (demisto#33088)

* "contribution update to pack "PAN-OS by Palo Alto Networks""

* Update Panorama.yml

* Update Panorama.py

* Update Panorama.yml

* Update Panorama_test.py

* Update Panorama.yml

* Update Panorama.py

* pre-commit

* Update 2_1_21.md

* Update 2_1_21.md

* Apply suggestions from code review



* rn

* rn

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com>
Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
maimorag pushed a commit that referenced this pull request Feb 28, 2024
…k Update (#31985) (#33088)

* "contribution update to pack "PAN-OS by Palo Alto Networks""

* Update Panorama.yml

* Update Panorama.py

* Update Panorama.yml

* Update Panorama_test.py

* Update Panorama.yml

* Update Panorama.py

* pre-commit

* Update 2_1_21.md

* Update 2_1_21.md

* Apply suggestions from code review



* rn

* rn

---------

Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com>
Co-authored-by: amkoppad <82898085+amkoppad@users.noreply.github.com>
Co-authored-by: MLainer1 <mlainer@paloaltonetworks.com>
Co-authored-by: MLainer1 <93524335+MLainer1@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved External PR pending-contributor The PR is pending the response of its creator ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
6 participants