Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SentinelOne] Update argument computer_name of command sentinelone-list-agents #31988

Merged
merged 3 commits into from Jan 8, 2024
Merged

[SentinelOne] Update argument computer_name of command sentinelone-list-agents #31988

merged 3 commits into from Jan 8, 2024

Conversation

chloerongier
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

This PR updates the argument computer_name so the sentinelone-list-agents command will now be able to match partial computer names value (substring) which was not possible before.

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jan 5, 2024
@content-bot content-bot changed the base branch from master to contrib/chloerongier_dev-s1-crn January 5, 2024 15:05
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@YuvHayun YuvHayun changed the title Update argument computer_name of command sentinelone-list-agents [SentinelOne] Update argument computer_name of command sentinelone-list-agents Jan 7, 2024
@kgal-pan kgal-pan self-assigned this Jan 7, 2024
@kgal-pan
Copy link
Contributor

kgal-pan commented Jan 7, 2024

@munna-metron @parag-metron @saurabh-metron - Can you please review and approve these changes?

@munna-metron
Copy link
Contributor

@munna-metron @parag-metron @saurabh-metron - Can you please review and approve these changes?

HI @kgal-pan , reviewed the changes and those are looking good. Thanks
cc: @parag-metron @saurabh-metron

YuvHayun
YuvHayun suggested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added 1 small comment.
Just to make sure computerName__like is as shown in the endpoint docs?
can you add a link to it please?
At the meantime, triggering instance test.

Packs/SentinelOne/Integrations/SentinelOne-V2/SentinelOne-V2.yml
@@ -130,7 +130,7 @@ name: SentinelOne V2
script:
commands:
- arguments:
- description: The computer name by which to filter the results.
- description: The computer name by which to filter the results. It can match a partial computer name value (substring).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to edit the readme as well.

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 8, 2024
@content-bot
Copy link
Collaborator

content-bot commented Jan 8, 2024 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/748006

@YuvHayun
Copy link
Contributor

YuvHayun commented Jan 8, 2024

@chloerongier please also make sure you're up to date with master.

@chloerongier
Copy link
Contributor Author

Looks good, added 1 small comment. Just to make sure computerName__like is as shown in the endpoint docs? can you add a link to it please? At the meantime, triggering instance test.

Here is the URI to the doc "/api-doc/api-details?category=agents&api=get-agents" and a screenshot with the query params :
image

@YuvHayun
Copy link
Contributor

YuvHayun commented Jan 8, 2024

Looks good, added 1 small comment. Just to make sure computerName__like is as shown in the endpoint docs? can you add a link to it please? At the meantime, triggering instance test.

Here is the URI to the doc "/api-doc/api-details?category=agents&api=get-agents" and a screenshot with the query params : image

Thx!
So please just pull from master.

@YuvHayun YuvHayun added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. and removed ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jan 8, 2024
@YuvHayun
Copy link
Contributor

YuvHayun commented Jan 8, 2024

Merging to internal PR.
Thx for your contribution @chloerongier

@YuvHayun YuvHayun merged commit a3a5b16 into demisto:contrib/chloerongier_dev-s1-crn Jan 8, 2024
19 of 26 checks passed
@content-bot content-bot mentioned this pull request Jan 8, 2024
Merged
5 tasks
YuvHayun added a commit that referenced this pull request Jan 9, 2024
@content-bot @chloerongier @YuvHayun
[SentinelOne] Update argument computer_name of command sentinelone-li…
565d8b7 
…st-agents (#31988) (#32037)

* Update argument computer_name of command sentinelone-list-agents

* Update readme

Co-authored-by: chloerongier <150173582+chloerongier@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
dantavori pushed a commit that referenced this pull request Jan 14, 2024
@content-bot @chloerongier
@YuvHayun @dantavori
[SentinelOne] Update argument computer_name of command sentinelone-li…
44904ab 
…st-agents (#31988) (#32037)

* Update argument computer_name of command sentinelone-list-agents

* Update readme

Co-authored-by: chloerongier <150173582+chloerongier@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun requested changes

Assignees

@YuvHayun YuvHayun

@kgal-pan kgal-pan

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner-Approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
5 participants
@chloerongier @content-bot @kgal-pan @munna-metron @YuvHayun