New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] Microsoft Exchange On-Premise - Content Pack Update #32022
Merged
DeanArbel
merged 7 commits into
master
from
contrib/xsoar-contrib_os-ahmed-contrib-MicrosoftExchangeOnPremise
Jan 10, 2024
Merged
[Marketplace Contribution] Microsoft Exchange On-Premise - Content Pack Update #32022
DeanArbel
merged 7 commits into
master
from
contrib/xsoar-contrib_os-ahmed-contrib-MicrosoftExchangeOnPremise
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck Update (#31909) * "contribution update to pack "Microsoft Exchange On-Premise"" * fixed rn and UT * docker image and lint * docker image --------- Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com> Co-authored-by: yucohen <yucohen@paloaltonetworks.com>
content-bot
added
Contribution
Thank you! Contributions are always welcome!
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Internal PR
labels
Jan 7, 2024
…rosoftExchangeOnPremise
yucohen
approved these changes
Jan 8, 2024
This PR was automatically updated by a GitHub Action
To stop automatic version bumps, add the |
…rosoftExchangeOnPremise
…rosoftExchangeOnPremise
DeanArbel
deleted the
contrib/xsoar-contrib_os-ahmed-contrib-MicrosoftExchangeOnPremise
branch
January 10, 2024 12:01
dantavori
pushed a commit
that referenced
this pull request
Jan 14, 2024
…ck Update (#32022) * [Marketplace Contribution] Microsoft Exchange On-Premise - Content Pack Update (#31909) * "contribution update to pack "Microsoft Exchange On-Premise"" * fixed rn and UT * docker image and lint * docker image --------- Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com> Co-authored-by: yucohen <yucohen@paloaltonetworks.com> * Bump pack from version MicrosoftExchangeOnPremise to 2.0.15. --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com> Co-authored-by: yucohen <yucohen@paloaltonetworks.com> Co-authored-by: Content Bot <bot@demisto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Contribution
Thank you! Contributions are always welcome!
docs-approved
Internal PR
ready-for-instance-test
In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Status
Contributor
@os-ahmed
Notes
Line 732 is expecting the body type in lower case 'html' in order to generate the HTML body.
"message_body = HTMLBody(html_body) if body_type == 'html' and html_body else Body(body)"
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.