Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASM] - EXPANDR-2883 Playbook trigger suggestion #32045

Conversation

capanw
Copy link
Contributor

@capanw capanw commented Jan 8, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

EXPANDR-2883

Description

Playbook trigger suggestion for Cortex ASM pack

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Jan 8, 2024
@capanw capanw marked this pull request as draft January 8, 2024 19:05
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 8, 2024
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_EXPANDR-2883 January 8, 2024 19:06
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @capanw, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Jan 9, 2024
Copy link
Contributor

@johnnywilkes johnnywilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@capanw , looks good, not sure how you can test so lets ship and see

@capanw capanw marked this pull request as ready for review January 9, 2024 16:24
@capanw
Copy link
Contributor Author

capanw commented Jan 9, 2024

@johnnywilkes, thanks for the review.

@YuvHayun, This is ready for review.

@YuvHayun
Copy link
Contributor

Merging to internal pr.

@YuvHayun YuvHayun merged commit 978819d into demisto:contrib/PaloAltoNetworks_EXPANDR-2883 Jan 10, 2024
14 of 21 checks passed
YuvHayun added a commit that referenced this pull request Jan 10, 2024
* Playbook trigger suggestion

* readme changes

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
dantavori pushed a commit that referenced this pull request Jan 14, 2024
* Playbook trigger suggestion

* readme changes

Co-authored-by: Chait A <112722030+capanw@users.noreply.github.com>
Co-authored-by: YuvHayun <yhayun@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
4 participants