Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS IOA fetch query documentation #32202

Merged
merged 11 commits into from Jan 24, 2024
Merged

Conversation

anas-yousef
Copy link
Contributor

@anas-yousef anas-yousef commented Jan 14, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32199

Description

Improved error handling and readme documentation

Must have

  • Tests
  • Documentation

@anas-yousef anas-yousef self-assigned this Jan 14, 2024
@anas-yousef anas-yousef changed the title Ay cs ios fetch query issue CS IOA fetch query documentation Jan 14, 2024
Copy link

github-actions bot commented Jan 14, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon
   CrowdStrikeFalcon.py274277771%355–356, 364, 375–377, 379–383, 408, 412, 422–427, 429–430, 438, 445, 456–463, 480, 602, 605, 633–642, 663, 738, 776–777, 779, 782–784, 832, 862, 921–922, 924, 929, 932–933, 948–950, 955, 958–959, 974–975, 977, 982, 985–986, 1014, 1016, 1021–1022, 1032, 1034, 1039–1040, 1150, 1267, 1269, 1296, 1298, 1315–1316, 1319–1324, 1326–1327, 1348, 1352, 1387, 1391, 1482, 1494–1495, 1497–1498, 1501, 1503, 1507–1508, 1544, 1553, 1558, 1587, 1589, 1617, 1621, 1653, 1655, 1782, 1787, 1798–1800, 1809–1813, 1826, 1829–1836, 1838, 1840, 1853, 1857, 1866, 1869–1870, 1873, 1882, 1885–1886, 1889, 1905, 1937, 1943–1946, 1949, 1953, 2003–2004, 2006, 2010, 2013, 2016, 2020–2021, 2024, 2039, 2195–2199, 2203, 2206, 2209–2210, 2213–2215, 2217, 2226, 2275–2276, 2278–2279, 2281–2283, 2316–2320, 2405, 2444–2447, 2450, 2453, 2455–2456, 2499–2501, 2504–2506, 2508, 2529, 2619, 2642–2643, 2700–2701, 2749, 3001–3002, 3187, 3291–3292, 3294, 3332–3337, 3387–3390, 3459, 3466, 3504, 3593, 3608, 3626, 3639, 3660–3663, 3676–3680, 3682–3683, 3685–3686, 3694–3702, 3709, 3753, 3759, 3787–3795, 3797–3798, 3806–3819, 3821–3823, 3825–3827, 3829–3831, 3833, 3835, 3837, 3849–3857, 3859–3869, 3877–3880, 3888–3891, 3927–3930, 3949–3954, 3956–3957, 3959–3966, 3976–3977, 3980, 4196–4198, 4205, 4227–4230, 4242, 4273–4276, 4292, 4324–4327, 4347–4348, 4358, 4371–4372, 4374, 4383–4386, 4427–4428, 4446–4449, 4494–4497, 4529, 4534–4535, 4560, 4564, 4576, 4578–4579, 4616–4617, 4623, 4644–4645, 4661–4662, 4676, 4690, 4693–4694, 4702, 4705–4706, 4717, 4721, 4760–4762, 4770–4772, 4774, 4801–4810, 4841, 4908–4911, 4914–4915, 4919–4922, 4925–4926, 4935–4936, 4938, 4940, 4942, 4944–4946, 4950, 4964–4968, 5033–5035, 5037, 5040, 5042, 5045, 5047–5049, 5051, 5053–5054, 5058–5061, 5066, 5068–5069, 5073–5074, 5076–5080, 5084, 5144, 5165–5166, 5245–5254, 5264, 5268, 5270, 5274, 5589, 5600, 5671, 5673, 5682, 5688, 5755, 5762, 5767, 5769, 5779, 5785, 5790, 5792–5793, 5795–5797, 5799, 5807, 5825, 5834, 5840, 5858, 5866, 5871, 5873–5874, 5876–5878, 5880, 5888, 5918, 5924, 5929, 5931, 5940, 5946, 5951, 5953–5954, 5956–5958, 5960, 5968, 6022, 6024–6025, 6027–6028, 6030, 6074–6075, 6077–6078, 6085, 6087, 6092, 6171, 6200–6201, 6209–6211, 6215, 6279, 6331, 6384, 6481, 6555–6556, 6558, 6560, 6577–6579, 6581–6586, 6588–6651, 6653–6664, 6671–6684, 6686–6687, 6689–6690, 6698–6699, 6701–6702, 6704–6705, 6707–6708, 6710–6714, 6718–6722, 6726–6727, 6729–6734, 6736–6739, 6741–6746, 6748–6791, 6793–6806, 6808, 6810–6811
TOTAL274277771% 

Tests Skipped Failures Errors Time
298 0 💤 2 ❌ 0 🔥 6.188s ⏱️

@anas-yousef
Copy link
Contributor Author

anas-yousef commented Jan 24, 2024

@yuvalbenshalom This will require force merge, the TPB Retrieve File from Endpoint - Generic V3 Test keeps on failing, even though we did not edit anything that may affect it. We opened a dummy PR that only adds a log message, and the TPB still failed. A developer is fixing the issue in the TPB.

@anas-yousef anas-yousef marked this pull request as ready for review January 24, 2024 13:16
@yuvalbenshalom yuvalbenshalom merged commit 3d621f5 into master Jan 24, 2024
18 of 19 checks passed
@yuvalbenshalom yuvalbenshalom deleted the ay-cs-ios-fetch-query-issue branch January 24, 2024 15:34
maimorag pushed a commit that referenced this pull request Jan 24, 2024
* Improved error handling, and documentation

* Deleted debug logs

* Updated RNs

* Docker update and error message handling

* Added to tooltip

---------

Co-authored-by: Jasmine Beilin <71636766+JasBeilin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants