Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adoption for Netwitness pack #32285

Merged
merged 5 commits into from Jan 22, 2024
Merged

Adoption for Netwitness pack #32285

merged 5 commits into from Jan 22, 2024

Conversation

adit-ghildiyal
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Jan 17, 2024
@content-bot content-bot changed the base branch from master to contrib/adit-ghildiyal_master January 17, 2024 19:03
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yucohen will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @adit-ghildiyal, thanks for contributing to a Cortex XSOAR supported pack. To receive credit for your generous contribution please follow this link.

@edik24 edik24 self-assigned this Jan 18, 2024
@edik24
Copy link
Contributor

edik24 commented Jan 18, 2024

@adit-ghildiyal plese sign CLA and fill the contribution registration form

@adit-ghildiyal
Copy link
Contributor Author

@adit-ghildiyal plese sign CLA and fill the contribution registration form

@edik24 Done

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Jan 18, 2024
yucohen
yucohen approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@yucohen yucohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Please see my comment

Packs/RSANetWitness_v11_1/ReleaseNotes/3_2_3.md
Comment on lines +1 to +3
##### RSANetWitness_v11_1

- Started adoption process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
##### RSANetWitness_v11_1
- Started adoption process.
#### Integrations
##### RSANetWitness_v11_1
- Started adoption process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yucohen I have updated the changes. Also we (Netwitess) will also be adopting the Packets and logs pack as well. PLease have a look

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adit-ghildiyal thanks!
I see that the validations are still failing, but I'll merge and fix it internally :)

@yucohen yucohen added the pending-contributor The PR is pending the response of its creator label Jan 21, 2024
@yucohen yucohen merged commit 869ee96 into demisto:contrib/adit-ghildiyal_master Jan 22, 2024
16 of 20 checks passed
@content-bot content-bot mentioned this pull request Jan 22, 2024
Merged
5 tasks
yucohen added a commit that referenced this pull request Jan 22, 2024
@content-bot @adit-ghildiyal @yucohen
Adoption for Netwitness pack (#32341)
0b0bc65 
* Adoption for Netwitness pack (#32285)

* Adoption process for Netwitness pack.

* Adoption process for Netwitness pack.

* Adoption process : Netwitness Log and Packets Pack

* Updates

* updated rn to force format

---------

Co-authored-by: adit-ghildiyal <156281269+adit-ghildiyal@users.noreply.github.com>
Co-authored-by: yucohen <yucohen@paloaltonetworks.com>
Co-authored-by: Yuval Cohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yucohen yucohen yucohen approved these changes

Assignees

@marcellarichmond marcellarichmond

@edik24 edik24

@yucohen yucohen

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Partner-Approved pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Milestone
No milestone
6 participants
@adit-ghildiyal @CLAassistant @content-bot @edik24 @yucohen @marcellarichmond