Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTIR integration: allow updating the MemberOf/Members #32288

Merged
merged 10 commits into from Jan 24, 2024
Merged

Conversation

moishce
Copy link
Contributor

@moishce moishce commented Jan 18, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

allow updating the MemberOf/Members in create/update commands

Must have

  • Tests
  • Documentation

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the design doc I see that the enhcnament was not meant to be added to the rtir-create-ticket command. Why have we add this?

Packs/RTIR/ReleaseNotes/1_0_20.md Outdated Show resolved Hide resolved
Packs/RTIR/Integrations/RTIR/RTIR.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, see pre-commit right comment.

Packs/RTIR/Integrations/RTIR/RTIR.py Outdated Show resolved Hide resolved
Packs/RTIR/Integrations/RTIR/RTIR.py Outdated Show resolved Hide resolved
@ShahafBenYakir
Copy link
Contributor

Just fix the descriptions

@moishce moishce merged commit 9b200bb into master Jan 24, 2024
15 of 16 checks passed
@moishce moishce deleted the rtir-links branch January 24, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants