[Netskope Event Collector] Add support for event type selection #32300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelFain
changed the title
Updated logic to handle fetching specific events
…r-add-event-type-selection
…r-add-event-type-selection
JasBeilin
reviewed
Jan 21, 2024
Comment on lines
301
to
311
| def handle_event_types_to_fetch(event_types_to_fetch) -> list[str]: | ||
| """ Handle event_types_to_fetch parameter. | ||
| Transform the event_types_to_fetch parameter into a pythonic list with lowercase values. | ||
| """ | ||
| def format_event_type_name(event_name: str) -> str: | ||
| return event_name.lower() | ||
|
|
||
| return argToList( | ||
| arg=event_types_to_fetch, | ||
| transform=format_event_type_name, | ||
| ) |
There was a problem hiding this comment.
While I love functions, we can make this a one liner-
Suggested change
| def handle_event_types_to_fetch(event_types_to_fetch) -> list[str]: | |
| """ Handle event_types_to_fetch parameter. | |
| Transform the event_types_to_fetch parameter into a pythonic list with lowercase values. | |
| """ | |
| def format_event_type_name(event_name: str) -> str: | |
| return event_name.lower() | |
| return argToList( | |
| arg=event_types_to_fetch, | |
| transform=format_event_type_name, | |
| ) | |
| def handle_event_types_to_fetch(event_types_to_fetch) -> list[str]: | |
| """ Handle event_types_to_fetch parameter. | |
| Transform the event_types_to_fetch parameter into a pythonic list with lowercase values. | |
| """ | |
| return argToList( | |
| arg=event_types_to_fetch, | |
| transform=lambda x: x.lower(), | |
| ) |
| name: event_types_to_fetch | ||
| type: 16 | ||
| required: false | ||
| additionalinfo: 'Event types to be fetched by this instance. Default is: Application, Alert, Page, Audit, Network.' |
There was a problem hiding this comment.
Suggested change
| additionalinfo: 'Event types to be fetched by this instance. Default is: Application, Alert, Page, Audit, Network.' | |
| additionalinfo: 'Event types to fetch. Default is all available types: Application, Alert, Page, Audit, Network.' |
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector_test.py
Show resolved
Hide resolved
Packs/Netskope/Integrations/NetskopeEventCollector/NetskopeEventCollector_test.py
Show resolved
Hide resolved
Minor updates to logic and UT
Add nextTrigger key-value pair to lastRun dictionary
…r-add-event-type-selection
docker image; release notes
samuelFain
deleted the
feature/XSUP-32126/netskope-event-collector-add-event-type-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: XSUP-32126
Description
Add the
Event Types To Fetchparameter to support fetching of specific event types.Must have