Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MITRE ATT&CK Improve error handling #32304

Merged
merged 5 commits into from Jan 25, 2024
Merged

MITRE ATT&CK Improve error handling #32304

merged 5 commits into from Jan 25, 2024

Conversation

BEAdi
Copy link
Contributor

@BEAdi BEAdi commented Jan 18, 2024

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-32452

Description

Add error messages.

Must have

  • Tests
  • Documentation

@BEAdi BEAdi self-assigned this Jan 18, 2024
@BEAdi BEAdi requested a review from MLainer1 as a code owner January 24, 2024 11:30
Copy link
Contributor

@MLainer1 MLainer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@BEAdi
Copy link
Contributor Author

BEAdi commented Jan 25, 2024

@yuvalbenshalom The error is because the coverage got smaller. The addition here is exceptions handling for general cases that is irrelevant to check in a UT.

@yuvalbenshalom yuvalbenshalom merged commit 6dfee58 into master Jan 25, 2024
21 of 22 checks passed
@yuvalbenshalom yuvalbenshalom deleted the mitre_exception branch January 25, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants